linux-kernel - Re: [PATCH] platform/x86/amd/hsmp: switch to use device_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e73426f6-6d50-4ed7-8613-1ec42fa3f991@amd.com>
Date: Thu, 1 Feb 2024 18:50:33 +0530
From: "Hegde, Suma" <Suma.Hegde@....com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: naveenkrishna.chatradhi@....com, LKML <linux-kernel@...r.kernel.org>,
 Carlos Bilbao <carlos.bilbao@....com>, Hans de Goede <hdegoede@...hat.com>,
 platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH] platform/x86/amd/hsmp: switch to use device_add_groups()

On 1/29/2024 6:16 PM, Ilpo Järvinen wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> + Cc Suma Hegde.
>
> On Sun, 28 Jan 2024, Greg Kroah-Hartman wrote:
>
>> The use of devm_*() functions works properly for when the device
>> structure itself is dynamic, but the hsmp driver is attempting to have a
>> local, static, struct device and then calls devm_() functions attaching
>> memory to the device that will never be freed.
>>
>> The logic of having a static struct device is almost never a wise
>> choice, but for now, just remove the use of devm_device_add_groups() in
>> this driver as it obviously is not needed.

Hi Greg,

Could you please hold on merging this patch for a week? I will push a 
patch for converting platform specific structure's memory allocation 
from static to a dynamic

allocation.

>>
>> Cc: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@....com>
>> Cc: Carlos Bilbao <carlos.bilbao@....com>
>> Cc: Hans de Goede <hdegoede@...hat.com>
>> Cc: "Ilpo Järvinen" <ilpo.jarvinen@...ux.intel.com>
>> Cc: platform-driver-x86@...r.kernel.org
>> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> ---
>>   drivers/platform/x86/amd/hsmp.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/platform/x86/amd/hsmp.c b/drivers/platform/x86/amd/hsmp.c
>> index b55d80e29139..49ef0b1d6df0 100644
>> --- a/drivers/platform/x86/amd/hsmp.c
>> +++ b/drivers/platform/x86/amd/hsmp.c
>> @@ -471,7 +471,7 @@ static int hsmp_create_sysfs_interface(void)
>>                if (ret)
>>                        return ret;
>>        }
>> -     return devm_device_add_groups(plat_dev.dev, hsmp_attr_grps);
>> +     return device_add_groups(plat_dev.dev, hsmp_attr_grps);
>>   }
> Thanks Greg for bringing this up. I've added Suma who has some patches
> which change code around this area.
Thanks Ilpo for adding me. I will push patch to address above issue on 
top of "Add ACPI probing support for HSMP" patch series.
> --
>   i.

Thanks and Regards,

Suma