linux-kernel - Re: [PATCH-wq v2 3/5] workqueue: Thaw frozen pwq in workqueue_apply_unbound

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 4 Feb 2024 18:15:11 +0800
From: kernel test robot <lkp@...el.com>
To: Waiman Long <longman@...hat.com>, Tejun Heo <tj@...nel.org>,
	Lai Jiangshan <jiangshanlai@...il.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Juri Lelli <juri.lelli@...hat.com>,
	Cestmir Kalina <ckalina@...hat.com>,
	Alex Gladkov <agladkov@...hat.com>, Phil Auld <pauld@...hat.com>,
	Costa Shulyupin <cshulyup@...hat.com>,
	Waiman Long <longman@...hat.com>
Subject: Re: [PATCH-wq v2 3/5] workqueue: Thaw frozen pwq in
 workqueue_apply_unbound_cpumask()

Hi Waiman,

kernel test robot noticed the following build warnings:

[auto build test WARNING on tj-wq/for-next]
[also build test WARNING on next-20240202]
[cannot apply to linus/master v6.8-rc2]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Waiman-Long/workqueue-Skip-__WQ_DESTROYING-workqueues-when-updating-global-unbound-cpumask/20240203-234626
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-next
patch link:    https://lore.kernel.org/r/20240203154334.791910-4-longman%40redhat.com
patch subject: [PATCH-wq v2 3/5] workqueue: Thaw frozen pwq in workqueue_apply_unbound_cpumask()
config: x86_64-randconfig-122-20240204 (https://download.01.org/0day-ci/archive/20240204/202402041854.YeHAF3wV-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240204/202402041854.YeHAF3wV-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402041854.YeHAF3wV-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
   kernel/workqueue.c:361:40: sparse: sparse: duplicate [noderef]
   kernel/workqueue.c:361:40: sparse: sparse: multiple address spaces given: __percpu & __rcu
>> kernel/workqueue.c:6373:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
   kernel/workqueue.c:6373:25: sparse:    struct pool_workqueue *
   kernel/workqueue.c:6373:25: sparse:    struct pool_workqueue [noderef] __rcu *

vim +6373 kernel/workqueue.c

  6356	
  6357	/*
  6358	 * Check the given ordered workqueue to see if its non-default pwq's have
  6359	 * zero reference count and if so thaw the frozen default pwq.
  6360	 *
  6361	 * Return:
  6362	 * %true if dfl_pwq has been thawed or %false otherwise.
  6363	 */
  6364	static bool ordered_workqueue_ref_check(struct workqueue_struct *wq)
  6365	{
  6366		int refs = 0;
  6367		struct pool_workqueue *pwq;
  6368	
  6369		if (!READ_ONCE(wq->dfl_pwq->frozen))
  6370			return true;
  6371		mutex_lock(&wq->mutex);
  6372		for_each_pwq(pwq, wq) {
> 6373			if (pwq == wq->dfl_pwq)
  6374				continue;
  6375			refs += pwq->refcnt;
  6376		}
  6377		if (!refs)
  6378			thaw_pwq(wq->dfl_pwq);
  6379		mutex_unlock(&wq->mutex);
  6380		return !refs;
  6381	}
  6382	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki