linux-kernel - Re: [PATCH-wq v2 3/5] workqueue: Thaw frozen pwq in workqueue_apply_unbound

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 4 Feb 2024 11:07:17 -0500
From: Waiman Long <longman@...hat.com>
To: kernel test robot <lkp@...el.com>, Tejun Heo <tj@...nel.org>,
 Lai Jiangshan <jiangshanlai@...il.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
 Juri Lelli <juri.lelli@...hat.com>, Cestmir Kalina <ckalina@...hat.com>,
 Alex Gladkov <agladkov@...hat.com>, Phil Auld <pauld@...hat.com>,
 Costa Shulyupin <cshulyup@...hat.com>
Subject: Re: [PATCH-wq v2 3/5] workqueue: Thaw frozen pwq in
 workqueue_apply_unbound_cpumask()

On 2/4/24 05:15, kernel test robot wrote:
> Hi Waiman,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on tj-wq/for-next]
> [also build test WARNING on next-20240202]
> [cannot apply to linus/master v6.8-rc2]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Waiman-Long/workqueue-Skip-__WQ_DESTROYING-workqueues-when-updating-global-unbound-cpumask/20240203-234626
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-next
> patch link:    https://lore.kernel.org/r/20240203154334.791910-4-longman%40redhat.com
> patch subject: [PATCH-wq v2 3/5] workqueue: Thaw frozen pwq in workqueue_apply_unbound_cpumask()
> config: x86_64-randconfig-122-20240204 (https://download.01.org/0day-ci/archive/20240204/202402041854.YeHAF3wV-lkp@intel.com/config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240204/202402041854.YeHAF3wV-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202402041854.YeHAF3wV-lkp@intel.com/
>
> sparse warnings: (new ones prefixed by >>)
>     kernel/workqueue.c:361:40: sparse: sparse: duplicate [noderef]
>     kernel/workqueue.c:361:40: sparse: sparse: multiple address spaces given: __percpu & __rcu
>>> kernel/workqueue.c:6373:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
>     kernel/workqueue.c:6373:25: sparse:    struct pool_workqueue *
>     kernel/workqueue.c:6373:25: sparse:    struct pool_workqueue [noderef] __rcu *

OK, I didn't realize that a __rcu tag is added to the dfl_pwq in 6.9. 
Will change the patch series to use the appropriate helpers to avoid 
this kind of warnings.

Cheers,
Longman