[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240204212135.3158722-1-arnd@kernel.org>
Date: Sun, 4 Feb 2024 22:21:29 +0100
From: Arnd Bergmann <arnd@...nel.org>
To: Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>,
Ivan Orlov <ivan.orlov0322@...il.com>
Cc: Arnd Bergmann <arnd@...db.de>,
linux-sound@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [PATCH] ALSA: core: fix unit test dependencies
From: Arnd Bergmann <arnd@...db.de>
The Kunit tests fail to link when PCM support is disabled:
aarch64-linux-ld: sound/core/sound_kunit.o: in function `test_pcm_format_name':
sound_kunit.c:(.text+0x4c): undefined reference to `snd_pcm_format_name'
aarch64-linux-ld: sound_kunit.c:(.text+0x12c): undefined reference to `snd_pcm_format_name'
aarch64-linux-ld: sound/core/sound_kunit.o: in function `_test_fill_silence':
sound_kunit.c:(.text+0x284): undefined reference to `snd_pcm_format_set_silence'
aarch64-linux-ld: sound/core/sound_kunit.o: in function `test_format_signed':
sound_kunit.c:(.text+0x400): undefined reference to `snd_pcm_format_signed'
aarch64-linux-ld: sound_kunit.c:(.text+0x470): undefined reference to `snd_pcm_format_unsigned'
aarch64-linux-ld: sound/core/sound_kunit.o: in function `test_format_width':
sound_kunit.c:(.text+0x64c): undefined reference to `snd_pcm_format_width'
aarch64-linux-ld: sound_kunit.c:(.text+0x71c): undefined reference to `snd_pcm_format_width'
Add the appropriate dependencies.
Fixes: 3e39acf56ede ("ALSA: core: Add sound core KUnit test")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
sound/core/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/core/Kconfig b/sound/core/Kconfig
index 664c6ee2b5a1..9a44f259ccca 100644
--- a/sound/core/Kconfig
+++ b/sound/core/Kconfig
@@ -42,6 +42,7 @@ config SND_UMP_LEGACY_RAWMIDI
config SND_CORE_TEST
tristate "Sound core KUnit test"
depends on KUNIT
+ depends on SND_PCM
default KUNIT_ALL_TESTS
help
This options enables the sound core functions KUnit test.
--
2.39.2
Powered by blists - more mailing lists