linux-kernel - Re: [PATCH] ALSA: core: fix unit test dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 05 Feb 2024 08:08:07 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Ivan Orlov <ivan.orlov0322@...il.com>,
	Arnd Bergmann <arnd@...db.de>,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: core: fix unit test dependencies

On Sun, 04 Feb 2024 22:21:29 +0100,
Arnd Bergmann wrote:
> 
> From: Arnd Bergmann <arnd@...db.de>
> 
> The Kunit tests fail to link when PCM support is disabled:
> 
> aarch64-linux-ld: sound/core/sound_kunit.o: in function `test_pcm_format_name':
> sound_kunit.c:(.text+0x4c): undefined reference to `snd_pcm_format_name'
> aarch64-linux-ld: sound_kunit.c:(.text+0x12c): undefined reference to `snd_pcm_format_name'
> aarch64-linux-ld: sound/core/sound_kunit.o: in function `_test_fill_silence':
> sound_kunit.c:(.text+0x284): undefined reference to `snd_pcm_format_set_silence'
> aarch64-linux-ld: sound/core/sound_kunit.o: in function `test_format_signed':
> sound_kunit.c:(.text+0x400): undefined reference to `snd_pcm_format_signed'
> aarch64-linux-ld: sound_kunit.c:(.text+0x470): undefined reference to `snd_pcm_format_unsigned'
> aarch64-linux-ld: sound/core/sound_kunit.o: in function `test_format_width':
> sound_kunit.c:(.text+0x64c): undefined reference to `snd_pcm_format_width'
> aarch64-linux-ld: sound_kunit.c:(.text+0x71c): undefined reference to `snd_pcm_format_width'
> 
> Add the appropriate dependencies.
> 
> Fixes: 3e39acf56ede ("ALSA: core: Add sound core KUnit test")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks, but this was already fixed on for-next branch.


Takashi