linux-kernel - Re: [PATCH] fs/inode: Make too_many

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <02CFAD55-0733-4765-9160-153409AE050F@163.com>
Date: Mon, 5 Feb 2024 12:23:32 +0800
From: Hao Ge <gehao618@....com>
To: Hao Ge <gehao@...inos.cn>
Cc: akpm@...ux-foundation.org, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/inode: Make too_many_isolated return bool

Sorry, please ignore this patch due to an incorrect title. I will resend the correct one

> On Feb 5, 2024, at 10:28, Hao Ge <gehao@...inos.cn> wrote:
> 
> too_many_isolated should return bool which with the same name and
> similar functions in mm/compaction.c already returned bool
> 
> Signed-off-by: Hao Ge <gehao@...inos.cn>
> ---
> mm/vmscan.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 4f9c854ce6cc..143e4b8e8821 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -1744,17 +1744,17 @@ bool folio_isolate_lru(struct folio *folio)
>  * the LRU list will go small and be scanned faster than necessary, leading to
>  * unnecessary swapping, thrashing and OOM.
>  */
> -static int too_many_isolated(struct pglist_data *pgdat, int file,
> +static bool too_many_isolated(struct pglist_data *pgdat, int file,
>        struct scan_control *sc)
> {
>    unsigned long inactive, isolated;
>    bool too_many;
> 
>    if (current_is_kswapd())
> -        return 0;
> +        return false;
> 
>    if (!writeback_throttling_sane(sc))
> -        return 0;
> +        return false;
> 
>    if (file) {
>        inactive = node_page_state(pgdat, NR_INACTIVE_FILE);
> --
> 2.25.1