linux-kernel - Re: [PATCH] mtd: flashchip: explicitly include <linux/wait.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20240205142620.390286-1-miquel.raynal@bootlin.com>
Date: Mon,  5 Feb 2024 15:26:20 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Tudor Ambarus <tudor.ambarus@...aro.org>,
	miquel.raynal@...tlin.com,
	richard@....at
Cc: linux-mtd@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	Takahiro.Kuwano@...ineon.com
Subject: Re: [PATCH] mtd: flashchip: explicitly include <linux/wait.h>

On Mon, 2024-02-05 at 10:09:55 UTC, Tudor Ambarus wrote:
> While reviewing the hyperbus sfdp proposal the following problem was
> noticed:
> 
> In file included from ./include/linux/mtd/gen_probe.h:10,
>                  from drivers/mtd/hyperbus/hyperbus-sfdp.c:6:
> ./include/linux/mtd/flashchip.h:77:9: error: unknown type name ‘wait_queue_head_t’
>    77 |         wait_queue_head_t wq; /* Wait on here when we're waiting for the chip
>       |         ^~~~~~~~~~~~~~~~~
> 
> It is good practice to directly include all headers used, it avoids
> implicit dependencies and spurious breakage if someone rearranges
> headers and causes the implicit include to vanish.
> 
> Explicitly include <linux/wait.h> in include/linux/mtd/flashchip.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@...aro.org>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel