linux-kernel - Re: [PATCH] leds: trigger: netdev: Fix kernel panic on interface rename trig notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240205142735.GA53266@google.com>
Date: Mon, 5 Feb 2024 14:27:35 +0000
From: Lee Jones <lee@...nel.org>
To: Andrew Lunn <andrew@...n.ch>
Cc: Christian Marangi <ansuelsmth@...il.com>, Pavel Machek <pavel@....cz>,
	"David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Daniel Golle <daniel@...rotopia.org>,
	Li Zetao <lizetao1@...wei.com>, linux-leds@...r.kernel.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] leds: trigger: netdev: Fix kernel panic on interface
 rename trig notify

On Mon, 05 Feb 2024, Andrew Lunn wrote:

> > > This should have 'net' in the subject line, to indicate which tree its
> > > for.
> > 
> > No, it shouldn't.
> > 
> > Contributors aren't obliged to know anything about merging strategies.
> 
> With netdev, we tend to assume they do, or at least can contribute to
> the discussion. They often know about any dependencies etc which could
> influence the decision. When there are multiple subsystem maintainers
> involved, i tend to use To: to indicate the maintainer i think should
> merge the patch, and Cc: for the rest.

This isn't a netdev patch. :)

We make no such stipulation for any of the subsystems I maintain.

The subject line should indicate which subsystem the commit pertains to,
not which maintainer will merge it or which tree it's merged via.  In
this case, it's drivers/leds, so "leds: " is fine.

> > Why does this need to go in via net?
> 
> It does not, as far as i'm aware. Christian, do you know of any
> reason?

It's pretty early in the cycle and there are no cross-subsystem deps
yet, as far as I'm aware.

-- 
Lee Jones [李琼斯]