linux-kernel - Re: [PATCH v1 4/4] mtd: mtdpart: Allow fwnode links to NVMEM compatible fwnodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 5 Feb 2024 16:11:29 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Michael Pratt <mcpratt@...me>
Cc: devicetree@...r.kernel.org, gregkh@...uxfoundation.org,
 linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org,
 saravanak@...gle.com, abel.vesa@...aro.org,
 alexander.stein@...tq-group.com, andriy.shevchenko@...ux.intel.com,
 bigunclemax@...il.com, brgl@...ev.pl, colin.foster@...advantage.com,
 djrscally@...il.com, dmitry.baryshkov@...aro.org, festevam@...il.com,
 fido_max@...ox.ru, frowand.list@...il.com, geert@...ux-m68k.org,
 heikki.krogerus@...ux.intel.com, kernel@...gutronix.de,
 linus.walleij@...aro.org, linux@...ck-us.net, luca.weiss@...rphone.com,
 magnus.damm@...il.com, martin.kepplinger@...i.sm, rafal@...ecki.pl,
 ansuelsmth@...il.com, richard@....at, sakari.ailus@...ux.intel.com,
 sudeep.holla@....com, tglx@...utronix.de, tony@...mide.com,
 vigneshr@...com, dianders@...omium.org, jpb@...nel.org, rafael@...nel.org
Subject: Re: [PATCH v1 4/4] mtd: mtdpart: Allow fwnode links to NVMEM
 compatible fwnodes

Hi Michael,

mcpratt@...me wrote on Tue, 23 Jan 2024 01:47:21 +0000:

> This reverts commit fb42378dcc7f247df56f0ecddfdae85487495fbc
> ("mtd: mtdpart: Don't create platform device that'll never probe").
> 
> That commit is a manual named exception in order to avoid fw_devlink links
> to an "nvmem-cells" compatible node which is a descendant of the fwnode
> that represents the real supplier device that probes.
> 
> The commit does not work for newer cases, like the "fixed-layout"

Do you have plans for it? Because it is the modern description that is
now expected, so I don't feel convinced by all this work (which is
nevertheless considerable) if fixed-layouts are still broken?

> compatible nodes, but instead of adding another compatible string,
> remove this workaround as it is no longer needed after
> the previous few commits which handle the situation in a generic way
> for all supplier nodes that are a child or further descendant fwnode
> of a parent device that can probe, including when the consumer device
> has a probe attempt before the supplier device, by using an existing
> incorrect fwnode or device link to recreate the correct one.
> 
> Signed-off-by: Michael Pratt <mcpratt@...me>

Thanks,
Miquèl