linux-kernel - Re: [PATCH v2 2/4] spi: cadence-qspi: fix pointer reference in runtime PM hooks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZcD6yqc+o62x2AjA@finisterre.sirena.org.uk>
Date: Mon, 5 Feb 2024 15:12:10 +0000
From: Mark Brown <broonie@...nel.org>
To: Théo Lebrun <theo.lebrun@...tlin.com>
Cc: Apurva Nandan <a-nandan@...com>, Dhruva Gole <d-gole@...com>,
	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Gregory CLEMENT <gregory.clement@...tlin.com>,
	Vladimir Kondratiev <vladimir.kondratiev@...ileye.com>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	Tawfik Bayouk <tawfik.bayouk@...ileye.com>
Subject: Re: [PATCH v2 2/4] spi: cadence-qspi: fix pointer reference in
 runtime PM hooks

On Mon, Feb 05, 2024 at 03:57:30PM +0100, Théo Lebrun wrote:
> dev_get_drvdata() gets used to acquire the pointer to cqspi and the SPI
> controller. Neither embed the other; this lead to memory corruption.
> 
> On a given platform (Mobileye EyeQ5) the memory corruption is hidden
> inside cqspi->f_pdata. Also, this uninitialised memory is used as a
> mutex (ctlr->bus_lock_mutex) by spi_controller_suspend().

Please place fixes at the start of serieses so that they don't end up
with spurious dependencies on other changes and can more easily be
applied as fixes.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)