linux-kernel - Re: [PATCH v2 2/4] interconnect: qcom: sc7280: enable QoS configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 5 Feb 2024 16:12:10 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Odelu Kukatla <quic_okukatla@...cinc.com>, djakov@...nel.org
Cc: rafael@...nel.org, corbet@....net, linux-pm@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 quic_viveka@...cinc.com, peterz@...radead.org, quic_mdtipton@...cinc.com,
 linux-arm-msm@...r.kernel.org, konrad.dybcio@...aro.org
Subject: Re: [PATCH v2 2/4] interconnect: qcom: sc7280: enable QoS
 configuration

On 05/02/2024 15:56, Odelu Kukatla wrote:
> Enable QoS configuration for the master ports with predefined values
> for priority and urgency.
> 
> Signed-off-by: Odelu Kukatla <quic_okukatla@...cinc.com>
> ---
>  drivers/interconnect/qcom/sc7280.c | 332 +++++++++++++++++++++++++++++
>  1 file changed, 332 insertions(+)
> 
> diff --git a/drivers/interconnect/qcom/sc7280.c b/drivers/interconnect/qcom/sc7280.c
> index 7d33694368e8..438f927935e5 100644
> --- a/drivers/interconnect/qcom/sc7280.c
> +++ b/drivers/interconnect/qcom/sc7280.c
> @@ -1,6 +1,7 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
>   * Copyright (c) 2021, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved.
>   *
>   */
>  
> @@ -16,29 +17,53 @@
>  #include "icc-rpmh.h"
>  #include "sc7280.h"
>  
> +static struct qcom_icc_qosbox qhm_qspi_qos = {

Why this cannot be const?

> +	.num_ports = 1,
> +	.port_offsets = { 0x7000 },
> +	.prio = 2,
> +	.urg_fwd = 0,


Best regards,
Krzysztof