linux-kernel - Re: [PATCH v2 1/4] interconnect: qcom: icc-rpmh: Add QoS configuration support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202402061541.oNi4V6C6-lkp@intel.com>
Date: Tue, 6 Feb 2024 15:55:08 +0800
From: kernel test robot <lkp@...el.com>
To: Odelu Kukatla <quic_okukatla@...cinc.com>, djakov@...nel.org
Cc: oe-kbuild-all@...ts.linux.dev, rafael@...nel.org, corbet@....net,
	linux-pm@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, quic_okukatla@...cinc.com,
	quic_viveka@...cinc.com, peterz@...radead.org,
	quic_mdtipton@...cinc.com, linux-arm-msm@...r.kernel.org,
	konrad.dybcio@...aro.org, krzysztof.kozlowski@...aro.org
Subject: Re: [PATCH v2 1/4] interconnect: qcom: icc-rpmh: Add QoS
 configuration support

Hi Odelu,

kernel test robot noticed the following build errors:

[auto build test ERROR on robh/for-next]
[also build test ERROR on linus/master v6.8-rc3 next-20240205]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Odelu-Kukatla/interconnect-qcom-icc-rpmh-Add-QoS-configuration-support/20240205-230208
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20240205145606.16936-2-quic_okukatla%40quicinc.com
patch subject: [PATCH v2 1/4] interconnect: qcom: icc-rpmh: Add QoS configuration support
config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20240206/202402061541.oNi4V6C6-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240206/202402061541.oNi4V6C6-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402061541.oNi4V6C6-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/interconnect/qcom/icc-rpmh.c: In function 'qcom_icc_set_qos':
>> drivers/interconnect/qcom/icc-rpmh.c:46:36: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
      46 |                                    FIELD_PREP(QOS_DISABLE_MASK, qos->prio_fwd_disable));
         |                                    ^~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/FIELD_PREP +46 drivers/interconnect/qcom/icc-rpmh.c

    25	
    26	/**
    27	 * qcom_icc_set_qos - initialize static QoS configurations
    28	 * @qp: qcom icc provider to which @node belongs
    29	 * @node: qcom icc node to operate on
    30	 */
    31	static void qcom_icc_set_qos(struct qcom_icc_provider *qp,
    32					struct qcom_icc_node *node)
    33	{
    34		const struct qcom_icc_qosbox *qos = node->qosbox;
    35		int port;
    36	
    37		if (!qp->regmap)
    38			return;
    39	
    40		if (!qos)
    41			return;
    42	
    43		for (port = 0; port < qos->num_ports; port++) {
    44			regmap_update_bits(qp->regmap, QOSGEN_MAINCTL_LO(qos, port),
    45					   QOS_DISABLE_MASK,
  > 46					   FIELD_PREP(QOS_DISABLE_MASK, qos->prio_fwd_disable));
    47	
    48			regmap_update_bits(qp->regmap, QOSGEN_MAINCTL_LO(qos, port),
    49					   QOS_DFLT_PRIO_MASK,
    50					   FIELD_PREP(QOS_DFLT_PRIO_MASK, qos->prio));
    51	
    52			regmap_update_bits(qp->regmap, QOSGEN_MAINCTL_LO(qos, port),
    53					   QOS_SLV_URG_MSG_EN_MASK,
    54					   FIELD_PREP(QOS_SLV_URG_MSG_EN_MASK, qos->urg_fwd));
    55		}
    56	}
    57	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki