linux-kernel - Re: [PATCH net-next v5 00/21] ice: add PFCP filter support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240206073759.4d948d1e@kernel.org>
Date: Tue, 6 Feb 2024 07:37:59 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Alexander Lobakin <aleksander.lobakin@...el.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Michal Swiatkowski
 <michal.swiatkowski@...ux.intel.com>, Marcin Szycik
 <marcin.szycik@...ux.intel.com>, Wojciech Drewek
 <wojciech.drewek@...el.com>, Yury Norov <yury.norov@...il.com>, Andy
 Shevchenko <andy@...nel.org>, "Rasmus Villemoes"
 <linux@...musvillemoes.dk>, Alexander Potapenko <glider@...gle.com>, Jiri
 Pirko <jiri@...nulli.us>, Ido Schimmel <idosch@...dia.com>, Przemek Kitszel
 <przemyslaw.kitszel@...el.com>, "Simon Horman" <horms@...nel.org>,
 <linux-btrfs@...r.kernel.org>, <dm-devel@...hat.com>,
 <ntfs3@...ts.linux.dev>, <linux-s390@...r.kernel.org>,
 <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v5 00/21] ice: add PFCP filter support

On Tue, 6 Feb 2024 13:46:44 +0100 Alexander Lobakin wrote:
> > Add support for creating PFCP filters in switchdev mode. Add pfcp module
> > that allows to create a PFCP-type netdev. The netdev then can be passed to
> > tc when creating a filter to indicate that PFCP filter should be created.  
> 
> I believe folks agreed that bitmap_{read,write}() should stay inline,
> ping then?

It's probably fine, IMHO. I mean, I think we agree that the rarely used
inlines should not sit in a header included by half of the kernel (not
an exaggeration). But IMHO a better fix would be to move out whatever
cpumask.h xarray.h and other common headers depend on to a cut-down
version rather than making your helpers not inline.

So I think all we need for now is for people to ack the respective
patches? Looks like cio and ntfs and missing acks, so are some of 
the bitops core patches.