linux-kernel - Re: [PATCH] regmap: kunit: fix raw noinc write test wrapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZcJSc595GcjDC4QK@finisterre.sirena.org.uk>
Date: Tue, 6 Feb 2024 15:38:27 +0000
From: Mark Brown <broonie@...nel.org>
To: Ben Wolsieffer <ben.wolsieffer@...ring.com>
Cc: linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH] regmap: kunit: fix raw noinc write test wrapping

On Tue, Feb 06, 2024 at 10:10:05AM -0500, Ben Wolsieffer wrote:
> The raw noinc write test places a known value in the register following
> the noinc register to verify that it is not disturbed by the noinc
> write. This test ensures this value is distinct by adding 100 to the
> second element of the noinc write data.
> 
> The regmap registers are 16-bit, while the test value is stored in an
> unsigned int. Therefore, adding 100 may cause the register to wrap while
> the test value does not, causing the test to fail. This patch fixes this
> by changing val_test and val_last from unsigned int to u16.

Ah, that'd do it!  I wonder why Guenter is seeing this with much greater
frequency than I am, I have managed to reproduce a few times this
afternoon but very rarely.  Guenter, does this fix the issues you're
seeing?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)