linux-kernel - Re: [PATCH] dt-bindings: mfd: Update pattern property case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 6 Feb 2024 08:35:58 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Naresh Solanki <naresh.solanki@...ements.com>
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Patrick Rudolph <patrick.rudolph@...ements.com>, mazziesaccount@...il.com,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: mfd: Update pattern property case

On 05/02/2024 15:00, Naresh Solanki wrote:
> Hi Krzysztof,
> 
> 
> On Mon, 5 Feb 2024 at 18:38, Krzysztof Kozlowski
> <krzysztof.kozlowski@...aro.org> wrote:
>>
>> On 05/02/2024 12:02, Naresh Solanki wrote:
>>> Driver expects regulator child node in upper case.
>>> Hence align with the same.
>>
>> Did the driver have DT support before? I think no, so why aligning that
>> way? I would argue that driver should be aligned with bindings, the
>> moment you add DT for the first time.
> Yes the driver has DT support already.
> This patch is to align with driver:
> https://github.com/torvalds/linux/blob/master/drivers/regulator/max5970-regulator.c#L381

That's not support for DT, but just naming regulators.

> 
> It was aligned but I missed on case sensitivity.

I don't see the alignment. Where did you align it? Which commit?

> Driver expects it to be SW0/SW1
> but DT had it as sw0/sw1.


Best regards,
Krzysztof