linux-kernel - Re: [PATCH] dt-bindings: mfd: Update pattern property case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 5 Feb 2024 19:30:42 +0530
From: Naresh Solanki <naresh.solanki@...ements.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh+dt@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	Patrick Rudolph <patrick.rudolph@...ements.com>, mazziesaccount@...il.com, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: mfd: Update pattern property case

Hi Krzysztof,


On Mon, 5 Feb 2024 at 18:38, Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> On 05/02/2024 12:02, Naresh Solanki wrote:
> > Driver expects regulator child node in upper case.
> > Hence align with the same.
>
> Did the driver have DT support before? I think no, so why aligning that
> way? I would argue that driver should be aligned with bindings, the
> moment you add DT for the first time.
Yes the driver has DT support already.
This patch is to align with driver:
https://github.com/torvalds/linux/blob/master/drivers/regulator/max5970-regulator.c#L381

It was aligned but I missed on case sensitivity.
Driver expects it to be SW0/SW1
but DT had it as sw0/sw1.

Regards,
Naresh

>
> Best regards,
> Krzysztof
>