[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e0893d21-606e-429e-a554-c9ee60fd0ae4@suse.de>
Date: Wed, 7 Feb 2024 17:36:24 +0100
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc: Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin
<npiggin@...il.com>, Christophe Leroy <christophe.leroy@...roup.eu>,
"Aneesh Kumar K . V" <aneesh.kumar@...nel.org>,
"Naveen N . Rao" <naveen.n.rao@...ux.ibm.com>,
linuxppc-dev@...ts.ozlabs.org, Geoff Levand <geoff@...radead.org>,
linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v2] drivers/ps3: select VIDEO to provide cmdline functions
Am 07.02.24 um 17:13 schrieb Randy Dunlap:
> When VIDEO is not set, there is a build error. Fix that by selecting
> VIDEO for PS3_PS3AV.
>
> ERROR: modpost: ".video_get_options" [drivers/ps3/ps3av_mod.ko] undefined!
>
> Fixes: dae7fbf43fd0 ("driver/ps3: Include <video/cmdline.h> for mode parsing")
> Fixes: a3b6792e990d ("video/cmdline: Introduce CONFIG_VIDEO for video= parameter")
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Cc: Nicholas Piggin <npiggin@...il.com>
> Cc: Christophe Leroy <christophe.leroy@...roup.eu>
> Cc: Aneesh Kumar K.V <aneesh.kumar@...nel.org>
> Cc: Naveen N. Rao <naveen.n.rao@...ux.ibm.com>
> Cc: linuxppc-dev@...ts.ozlabs.org
> Cc: Thomas Zimmermann <tzimmermann@...e.de>
> Cc: Geoff Levand <geoff@...radead.org>
> Acked-by: Geoff Levand <geoff@...radead.org>
> Cc: linux-fbdev@...r.kernel.org
> Cc: dri-devel@...ts.freedesktop.org
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>
> ---
> v2: add Geoff's Ack;
> add second Fixes: tag and more Cc:s (Thomas)
>
> arch/powerpc/platforms/ps3/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -- a/arch/powerpc/platforms/ps3/Kconfig b/arch/powerpc/platforms/ps3/Kconfig
> --- a/arch/powerpc/platforms/ps3/Kconfig
> +++ b/arch/powerpc/platforms/ps3/Kconfig
> @@ -67,6 +67,7 @@ config PS3_VUART
> config PS3_PS3AV
> depends on PPC_PS3
> tristate "PS3 AV settings driver" if PS3_ADVANCED
> + select VIDEO
> select PS3_VUART
> default y
> help
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
Powered by blists - more mailing lists