linux-kernel - Re: [PATCH v2] drivers/ps3: select VIDEO to provide cmdline functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8734u28bh8.fsf@mail.lhotse>
Date: Fri, 09 Feb 2024 16:15:15 +1100
From: Michael Ellerman <mpe@...erman.id.au>
To: Thomas Zimmermann <tzimmermann@...e.de>, Randy Dunlap
 <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc: Nicholas Piggin <npiggin@...il.com>, Christophe Leroy
 <christophe.leroy@...roup.eu>, "Aneesh Kumar K . V"
 <aneesh.kumar@...nel.org>, "Naveen N . Rao" <naveen.n.rao@...ux.ibm.com>,
 linuxppc-dev@...ts.ozlabs.org, Geoff Levand <geoff@...radead.org>,
 linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v2] drivers/ps3: select VIDEO to provide cmdline functions

Thomas Zimmermann <tzimmermann@...e.de> writes:
> Am 07.02.24 um 17:13 schrieb Randy Dunlap:
>> When VIDEO is not set, there is a build error. Fix that by selecting
>> VIDEO for PS3_PS3AV.
>>
>> ERROR: modpost: ".video_get_options" [drivers/ps3/ps3av_mod.ko] undefined!
>>
>> Fixes: dae7fbf43fd0 ("driver/ps3: Include <video/cmdline.h> for mode parsing")
>> Fixes: a3b6792e990d ("video/cmdline: Introduce CONFIG_VIDEO for video= parameter")
>> Cc: Michael Ellerman <mpe@...erman.id.au>
>> Cc: Nicholas Piggin <npiggin@...il.com>
>> Cc: Christophe Leroy <christophe.leroy@...roup.eu>
>> Cc: Aneesh Kumar K.V <aneesh.kumar@...nel.org>
>> Cc: Naveen N. Rao <naveen.n.rao@...ux.ibm.com>
>> Cc: linuxppc-dev@...ts.ozlabs.org
>> Cc: Thomas Zimmermann <tzimmermann@...e.de>
>> Cc: Geoff Levand <geoff@...radead.org>
>> Acked-by: Geoff Levand <geoff@...radead.org>
>> Cc: linux-fbdev@...r.kernel.org
>> Cc: dri-devel@...ts.freedesktop.org
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>

Can you take it via whatever tree the CONFIG_VIDEO patch is in?

Acked-by: Michael Ellerman <mpe@...erman.id.au>

cheers