linux-kernel - Re: [PATCH] kunit: device: Unregister the kunit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+GJov4zrcbiANMgJ5uSQs6Siv0+NAB5big0bec-WWgkhfFJ+Q@mail.gmail.com>
Date: Wed, 7 Feb 2024 16:11:38 -0500
From: Rae Moar <rmoar@...gle.com>
To: Jani Nikula <jani.nikula@...ux.intel.com>
Cc: David Gow <davidgow@...gle.com>, Shuah Khan <skhan@...uxfoundation.org>, 
	Matti Vaittinen <mazziesaccount@...il.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Brendan Higgins <brendan.higgins@...ux.dev>, Maxime Ripard <mripard@...nel.org>, 
	linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com, 
	linux-kernel@...r.kernel.org, 
	Chaitanya Kumar <chaitanya.kumar.borah@...el.com>, Jani <jani.saarinen@...el.com>, 
	Richard Fitzgerald <rf@...nsource.cirrus.com>, intel-gfx@...ts.freedesktop.org
Subject: Re: [PATCH] kunit: device: Unregister the kunit_bus on shutdown

On Wed, Feb 7, 2024 at 8:36 AM Jani Nikula <jani.nikula@...ux.intelcom> wrote:
>
> On Fri, 02 Feb 2024, Rae Moar <rmoar@...gle.com> wrote:
> > On Thu, Feb 1, 2024 at 1:06 AM David Gow <davidgow@...gle.com> wrote:
> >>
> >> If KUnit is built as a module, and it's unloaded, the kunit_bus is not
> >> unregistered. This causes an error if it's then re-loaded later, as we
> >> try to re-register the bus.
> >>
> >> Unregister the bus and root_device on shutdown, if it looks valid.
> >>
> >> In addition, be more specific about the value of kunit_bus_device. It
> >> is:
> >> - a valid struct device* if the kunit_bus initialised correctly.
> >> - an ERR_PTR if it failed to initialise.
> >> - NULL before initialisation and after shutdown.
> >>
> >> Fixes: d03c720e03bd ("kunit: Add APIs for managing devices")
> >> Signed-off-by: David Gow <davidgow@...gle.com>
> >
> > Hello,
> >
> > I have tested this with modules and it looks good to me!
> >
> > Thanks!
> > -Rae
> >
> > Reviewed-by: Rae Moar <rmoar@...gle.com>
>
> Thanks for the patch and review!
>
> Is this on its way to some v6.8-rc's? The regression in -rc1 is hurting
> our CI.

Hello!

This patch has been accepted on the kselftest/kunit-fixes branch
(https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/commit/?h=kunit-fixes&id=829388b725f8d266ccec32a2f446717d8693eaba)
and is heading towards a future v6.8-rc.

Thanks!
-Rae

>
>
> Thanks,
> Jani.
>
>
> --
> Jani Nikula, Intel