linux-kernel - Re: [PATCH] kunit: device: Unregister the kunit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878r3wcs7e.fsf@intel.com>
Date: Wed, 07 Feb 2024 15:35:49 +0200
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Rae Moar <rmoar@...gle.com>, David Gow <davidgow@...gle.com>
Cc: Shuah Khan <skhan@...uxfoundation.org>, Matti Vaittinen
 <mazziesaccount@...il.com>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, Brendan Higgins <brendan.higgins@...ux.dev>,
 Maxime Ripard <mripard@...nel.org>, linux-kselftest@...r.kernel.org,
 kunit-dev@...glegroups.com, linux-kernel@...r.kernel.org, Chaitanya Kumar
 <chaitanya.kumar.borah@...el.com>, Jani <jani.saarinen@...el.com>, Richard
 Fitzgerald <rf@...nsource.cirrus.com>, intel-gfx@...ts.freedesktop.org
Subject: Re: [PATCH] kunit: device: Unregister the kunit_bus on shutdown

On Fri, 02 Feb 2024, Rae Moar <rmoar@...gle.com> wrote:
> On Thu, Feb 1, 2024 at 1:06 AM David Gow <davidgow@...gle.com> wrote:
>>
>> If KUnit is built as a module, and it's unloaded, the kunit_bus is not
>> unregistered. This causes an error if it's then re-loaded later, as we
>> try to re-register the bus.
>>
>> Unregister the bus and root_device on shutdown, if it looks valid.
>>
>> In addition, be more specific about the value of kunit_bus_device. It
>> is:
>> - a valid struct device* if the kunit_bus initialised correctly.
>> - an ERR_PTR if it failed to initialise.
>> - NULL before initialisation and after shutdown.
>>
>> Fixes: d03c720e03bd ("kunit: Add APIs for managing devices")
>> Signed-off-by: David Gow <davidgow@...gle.com>
>
> Hello,
>
> I have tested this with modules and it looks good to me!
>
> Thanks!
> -Rae
>
> Reviewed-by: Rae Moar <rmoar@...gle.com>

Thanks for the patch and review!

Is this on its way to some v6.8-rc's? The regression in -rc1 is hurting
our CI.


Thanks,
Jani.


-- 
Jani Nikula, Intel