linux-kernel - Re: [PATCH v2] ALSA: hda/realtek: cs35l41: Fix internal speaker support for ASUS UM3402 with missing DSD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 07 Feb 2024 16:10:12 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Jean-Loïc Charroud <lagiraudiere+linux@...e.fr>
Cc: Takashi Iwai <tiwai@...e.de>,
	Stefan Binding <sbinding@...nsource.cirrus.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Richard Fitzgerald <rf@...nsource.cirrus.com>,
	linux-sound <linux-sound@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	patches <patches@...nsource.cirrus.com>
Subject: Re: [PATCH v2] ALSA: hda/realtek: cs35l41: Fix internal speaker support for ASUS UM3402 with missing DSD

On Wed, 07 Feb 2024 15:30:46 +0100,
Jean-Loïc Charroud wrote:
> 
> Fix device ID for "ASUS UM3402" and "ASUS UM6702RA/RC".

This change is only about the string in the table, not the actual
behavior, right?  The name string there is only for debug info, so
it's no big problem even if it's not 100% right.
That is, this can be again split to another patch -- with the
additional Fixes tag to the commit that introduced the entries.

> Add DSD values for "ASUS UM3402" to cs35l41_config_table[].

.. and this one is the mandatory fix for your device.  It should be
the patch 1.  Then we'll have two more, one for correcting the entry
names, and another for sorting the entries.

I'm a bit picky, but now you see how the things work.
Divide-and-conquer is the basic strategy.

Takashi