[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <87le7uvkx0.fsf@mailhost.krisman.be>
Date: Thu, 08 Feb 2024 14:02:51 -0500
From: Gabriel Krisman Bertazi <krisman@...e.de>
To: Eugen Hristev <eugen.hristev@...labora.com>
Cc: tytso@....edu, adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org,
linux-kernel@...r.kernel.org, kernel@...labora.co, Gabriel Krisman
Bertazi <krisman@...labora.com>, Eric Biggers <ebiggers@...gle.com>
Subject: Re: [RESEND PATCH v9] ext4: Log error when lookup of encoded dentry
fails
Eugen Hristev <eugen.hristev@...labora.com> writes:
> From: Gabriel Krisman Bertazi <krisman@...labora.com>
>
> If the volume is in strict mode, ext4_ci_compare can report a broken
> encoding name. This will not trigger on a bad lookup, which is caught
> earlier, only if the actual disk name is bad.
>
> Reviewed-by: Eric Biggers <ebiggers@...gle.com>
> Signed-off-by: Gabriel Krisman Bertazi <krisman@...labora.com>
> Signed-off-by: Eugen Hristev <eugen.hristev@...labora.com>
Reviewed-by: Gabriel Krisman Bertazi <krisman@...e.de>
> ---
> Hello,
>
> I am trying to respin the series here :
> https://www.spinics.net/lists/linux-ext4/msg85081.html
>
> To make it easier to apply I split it into smaller chunks which address
> one single thing.
>
> This patch simply adds an error message in the UNICODE path.
>
> fs/ext4/namei.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index 6e7af8dc4dde..7d357c417475 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c
> @@ -1477,6 +1477,9 @@ static bool ext4_match(struct inode *parent,
> * only case where it happens is on a disk
> * corruption or ENOMEM.
> */
> + if (ret == -EINVAL)
> + EXT4_ERROR_INODE(parent,
> + "Directory contains filename that is invalid UTF-8");
> return false;
> }
> return ret;
--
Gabriel Krisman Bertazi
Powered by blists - more mailing lists