[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2024020842-blaspheme-immortal-49dd@gregkh>
Date: Thu, 8 Feb 2024 18:52:21 +0000
From: Greg KH <gregkh@...uxfoundation.org>
To: Florian Fainelli <florian.fainelli@...adcom.com>
Cc: stable@...r.kernel.org, Russell King <rmk+kernel@...linux.org.uk>,
Jakub Kicinski <kuba@...nel.org>, Doug Berger <opendmb@...il.com>,
Florian Fainelli <f.fainelli@...il.com>,
"David S. Miller" <davem@...emloft.net>,
"open list:BROADCOM GENET ETHERNET DRIVER" <bcm-kernel-feedback-list@...adcom.com>,
"open list:BROADCOM GENET ETHERNET DRIVER" <netdev@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH stable 5.4] net: bcmgenet: Fix EEE implementation
On Thu, Feb 08, 2024 at 10:20:40AM -0800, Florian Fainelli wrote:
> commit a9f31047baca57d47440c879cf259b86f900260c upstream
>
> We had a number of short comings:
>
> - EEE must be re-evaluated whenever the state machine detects a link
> change as wight be switching from a link partner with EEE
> enabled/disabled
>
> - tx_lpi_enabled controls whether EEE should be enabled/disabled for the
> transmit path, which applies to the TBUF block
>
> - We do not need to forcibly enable EEE upon system resume, as the PHY
> state machine will trigger a link event that will do that, too
>
> Fixes: 6ef398ea60d9 ("net: bcmgenet: add EEE support")
> Signed-off-by: Florian Fainelli <florian.fainelli@...adcom.com>
> Reviewed-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> Link: https://lore.kernel.org/r/20230606214348.2408018-1-florian.fainelli@broadcom.com
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Florian Fainelli <florian.fainelli@...adcom.com>
> Change-Id: I9e9d9d9e10817c7fcf3d9cde2389a1f6fe42a2ba
"Change-Id:"? Ick, gerrit, so sorry :(
Please remove these.
thanks,
greg k-h
Powered by blists - more mailing lists