linux-kernel - Re: [PATCH v4 09/12] nvdimm/pmem: Cleanup alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 8 Feb 2024 17:12:43 -0500
From: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
To: Dan Williams <dan.j.williams@...el.com>, Arnd Bergmann <arnd@...db.de>,
 Dave Chinner <david@...morbit.com>
Cc: linux-kernel@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>,
 Linus Torvalds <torvalds@...ux-foundation.org>,
 Vishal Verma <vishal.l.verma@...el.com>, Dave Jiang <dave.jiang@...el.com>,
 Matthew Wilcox <willy@...radead.org>, Russell King <linux@...linux.org.uk>,
 linux-arch@...r.kernel.org, linux-cxl@...r.kernel.org,
 linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
 linux-xfs@...r.kernel.org, dm-devel@...ts.linux.dev, nvdimm@...ts.linux.dev,
 linux-s390@...r.kernel.org, Alasdair Kergon <agk@...hat.com>,
 Mike Snitzer <snitzer@...nel.org>, Mikulas Patocka <mpatocka@...hat.com>
Subject: Re: [PATCH v4 09/12] nvdimm/pmem: Cleanup alloc_dax() error handling

On 2024-02-08 16:55, Dan Williams wrote:
[...]
> 
> Oh... I see you cleanup what I was talking about later in the series.
> 
> For my taste I don't like to see tech-debt added and then removed later
> in the series. The whole series would appear to get smaller by removing
> the alloc_dax() returning NULL case from the beginning, and then doing
> the EOPNOTSUPP fixups.
> 
> ...repeat this comment for patch 10, 11, 12.

Done.

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com