linux-kernel - Re: [PATCH v6 2/5] dt-bindings: iio: light: adps9300: Add property vdd-supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 9 Feb 2024 08:33:11 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Subhajit Ghosh <subhajit.ghosh@...aklogic.com>,
 Jonathan Cameron <jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>,
 Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Matti Vaittinen <mazziesaccount@...il.com>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Marek Vasut <marex@...x.de>, Anshul Dalal <anshulusr@...il.com>,
 Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: Matt Ranostay <matt@...ostay.sg>,
 Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@...s.com>,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 2/5] dt-bindings: iio: light: adps9300: Add property
 vdd-supply

On 08/02/2024 11:40, Subhajit Ghosh wrote:
> Hi Krzysztof,
> 
> On 8/2/24 18:47, Krzysztof Kozlowski wrote:
>> On 06/02/2024 14:00, Subhajit Ghosh wrote:
>>> Add vdd-supply property which is valid and useful for all the
>>> devices in this schema.
>>
>> Why is it useful? How is it useful? DT describes the hardware, not
>> because something is "useful".
> I am adding this property based on a previous review:
> https://lore.kernel.org/all/20240121153655.5f734180@jic23-huawei/

The property was there already.

> 
> Does the below commit message in this context make sense to you?
> "Add vdd-supply property for all the devices in this schema."

It's still poor. You should say why, e.g. because devices have it.

>>
>>>
>>> this patch depends on patch:
>>> "dt-bindings: iio: light: Merge APDS9300 and APDS9960 schemas"
>>
>> This is unrelated and does not make any sense in commit msg. Drop.
> Apologies for the silly questions:
> What does the "Drop" signify? Are you asking me to drop/delete the above
> "...patch depends..." message or does it have any other meaning?

Drop entire paragraph.


Best regards,
Krzysztof