linux-kernel - RE: [PATCH] ALSA: hda/cs35l56: select intended config FW_CS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <001801da5b49$a89be460$f9d3ad20$@opensource.cirrus.com>
Date: Fri, 9 Feb 2024 11:18:07 +0000
From: Simon Trimmer <simont@...nsource.cirrus.com>
To: 'Lukas Bulwahn' <lukas.bulwahn@...il.com>,
        'Jaroslav Kysela'
	<perex@...ex.cz>, 'Takashi Iwai' <tiwai@...e.com>,
        'Richard Fitzgerald'
	<rf@...nsource.cirrus.com>,
        <linux-sound@...r.kernel.org>
CC: <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ALSA: hda/cs35l56: select intended config FW_CS_DSP

> -----Original Message-----
> From: Lukas Bulwahn <lukas.bulwahn@...il.com>
> 
> Commit 73cfbfa9caea ("ALSA: hda/cs35l56: Add driver for Cirrus Logic
> CS35L56 amplifier") adds configs SND_HDA_SCODEC_CS35L56_{I2C,SPI},
> which selects the non-existing config CS_DSP. Note the renaming in
> commit d7cfdf17cb9d ("firmware: cs_dsp: Rename KConfig symbol CS_DSP ->
> FW_CS_DSP"), though.
> 
> Select the intended config FW_CS_DSP.
> 
> This broken select command probably was not noticed as the configs also
> select SND_HDA_CS_DSP_CONTROLS and this then selects FW_CS_DSP. So,
> the
> select FW_CS_DSP could actually be dropped, but we will keep this
> redundancy in place as the author originally also intended to have this
> redundancy of selects in place.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>

Thanks!

Reviewed-by: Simon Trimmer <simont@...nsource.cirrus.com>