[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <87a5o923uc.wl-tiwai@suse.de>
Date: Fri, 09 Feb 2024 13:56:43 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc: Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>,
Richard Fitzgerald <rf@...nsource.cirrus.com>,
Simon Trimmer <simont@...nsource.cirrus.com>,
linux-sound@...r.kernel.org,
kernel-janitors@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda/cs35l56: select intended config FW_CS_DSP
On Fri, 09 Feb 2024 09:20:44 +0100,
Lukas Bulwahn wrote:
>
> Commit 73cfbfa9caea ("ALSA: hda/cs35l56: Add driver for Cirrus Logic
> CS35L56 amplifier") adds configs SND_HDA_SCODEC_CS35L56_{I2C,SPI},
> which selects the non-existing config CS_DSP. Note the renaming in
> commit d7cfdf17cb9d ("firmware: cs_dsp: Rename KConfig symbol CS_DSP ->
> FW_CS_DSP"), though.
>
> Select the intended config FW_CS_DSP.
>
> This broken select command probably was not noticed as the configs also
> select SND_HDA_CS_DSP_CONTROLS and this then selects FW_CS_DSP. So, the
> select FW_CS_DSP could actually be dropped, but we will keep this
> redundancy in place as the author originally also intended to have this
> redundancy of selects in place.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
Thanks, applied.
Takashi
Powered by blists - more mailing lists