linux-kernel - Re: [PATCH] Input: xpad - sort xpad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZcZ1Sn_iPwlgfI3s@google.com>
Date: Fri, 9 Feb 2024 10:56:10 -0800
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Brenton Simpson <appsforartists@...gle.com>
Cc: Hans de Goede <hdegoede@...hat.com>,
	Cameron Gutman <aicommander@...il.com>,
	Erica Taylor <rickytaylor26@...il.com>,
	Ismael Ferreras Morezuelas <swyterzone@...il.com>,
	Jonathan Frederick <doublej472@...il.com>,
	Matthias Benkmann <matthias.benkmann@...il.com>,
	Matthias Berndt <matthias_berndt@....de>, nate@...om.org,
	Sam Lantinga <slouken@...sdl.org>, Vicki Pfau <vi@...rift.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	trivial@...nel.org
Subject: Re: [PATCH] Input: xpad - sort xpad_device by vendor and product ID

Hi Brenton,

On Tue, Jan 30, 2024 at 11:19:03PM +0000, Brenton Simpson wrote:
> Signed-off-by: Brenton Simpson <appsforartists@...gle.com>

Empty patch descriptions are frowned upon. You should be able to add at
least a single sentence why the change is being made.

..

>  
>  static const struct usb_device_id xpad_table[] = {
> +	/* Please keep this list sorted by vendor ID.  Because the lines use different
> +	 * macros, you may need to sort it by hand.
> +	 */

Kernel style of multi-line comments is:

	/*
	 * line 1
	 * line 2.
	 */

I adjusted and applied, thank you.

Thanks.

-- 
Dmitry