linux-kernel - Re: [PATCH] iio: core: make iio_bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240210154504.0656f230@jic23-huawei>
Date: Sat, 10 Feb 2024 15:45:04 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Nuno Sá <noname.nuno@...il.com>
Cc: "Ricardo B. Marliere" <ricardo@...liere.net>, Lars-Peter Clausen
 <lars@...afoo.de>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] iio: core: make iio_bus_type const

On Fri, 09 Feb 2024 08:38:03 +0100
Nuno Sá <noname.nuno@...il.com> wrote:

> On Thu, 2024-02-08 at 16:37 -0300, Ricardo B. Marliere wrote:
> > Now that the driver core can properly handle constant struct bus_type,
> > move the iio_bus_type variable to be a constant structure as well,
> > placing it into read-only memory which can not be modified at runtime.
> > 
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Suggested-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Signed-off-by: Ricardo B. Marliere <ricardo@...liere.net>
> > ---  
> 
> Acked-by: Nuno Sa <nuno.sa@...log.com>
Applied. Thanks,

Jonathan

> 
> >  drivers/iio/industrialio-core.c | 2 +-
> >  include/linux/iio/iio.h         | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> > index e8551a1636ba..9b2877fe8689 100644
> > --- a/drivers/iio/industrialio-core.c
> > +++ b/drivers/iio/industrialio-core.c
> > @@ -42,7 +42,7 @@ static DEFINE_IDA(iio_ida);
> >  static dev_t iio_devt;
> >  
> >  #define IIO_DEV_MAX 256
> > -struct bus_type iio_bus_type = {
> > +const struct bus_type iio_bus_type = {
> >  	.name = "iio",
> >  };
> >  EXPORT_SYMBOL(iio_bus_type);
> > diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> > index 4f89279e531c..e370a7bb3300 100644
> > --- a/include/linux/iio/iio.h
> > +++ b/include/linux/iio/iio.h
> > @@ -669,7 +669,7 @@ DEFINE_GUARD_COND(iio_claim_direct, _try, ({
> >  int iio_device_claim_buffer_mode(struct iio_dev *indio_dev);
> >  void iio_device_release_buffer_mode(struct iio_dev *indio_dev);
> >  
> > -extern struct bus_type iio_bus_type;
> > +extern const struct bus_type iio_bus_type;
> >  
> >  /**
> >   * iio_device_put() - reference counted deallocation of struct device
> > 
> > ---
> > base-commit: 81e8e40ea16329914f78ca1f454d04f570540ca8
> > change-id: 20240208-bus_cleanup-iio-1e5714e23bb9
> > 
> > Best regards,  
>