linux-kernel - Re: [PATCH v3 3/5] iio: adc: ad7192: Use standard attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240210155226.5e509845@jic23-huawei>
Date: Sat, 10 Feb 2024 15:52:26 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Alisa-Dariana Roman <alisadariana@...il.com>
Cc: alexandru.tachici@...log.com, alisa.roman@...log.com,
 conor+dt@...nel.org, devicetree@...r.kernel.org, dlechner@...libre.com,
 krzysztof.kozlowski+dt@...aro.org, krzysztof.kozlowski@...aro.org,
 lars@...afoo.de, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
 michael.hennerich@...log.com, robh+dt@...nel.org
Subject: Re: [PATCH v3 3/5] iio: adc: ad7192: Use standard attribute

On Thu,  8 Feb 2024 19:24:57 +0200
Alisa-Dariana Roman <alisadariana@...il.com> wrote:

> Replace custom attribute filter_low_pass_3db_frequency_available with
> standard attribute.
> 
> Store the available values in ad7192_state struct.
> 
> The function that used to compute those values replaced by
> ad7192_update_filter_freq_avail().
> 
> Function ad7192_show_filter_avail() is no longer needed.
> 
> Note that the initial available values are hardcoded.
> 
> Signed-off-by: Alisa-Dariana Roman <alisa.roman@...log.com>
Looks good. Thanks for tidying this up.

I've nothing to add to other reviews that have already come in for v3.

Thanks,

Jonathan