linux-kernel - [PATCH] swiotlb-xen: remove redundant NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date: Sun, 11 Feb 2024 07:09:58 -0800
From: Daniil Dulov <d.dulov@...ddin.ru>
To: Juergen Gross <jgross@...e.com>
CC: Daniil Dulov <d.dulov@...ddin.ru>, Boris Ostrovsky
	<boris.ostrovsky@...cle.com>, Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Stefano Stabellini <sstabellini@...nel.org>, Jeremy Fitzhardinge
	<jeremy.fitzhardinge@...rix.com>, <xen-devel@...ts.xenproject.org>,
	<iommu@...ts.linux-foundation.org>, <linux-kernel@...r.kernel.org>,
	<lvc-project@...uxtesting.org>
Subject: [PATCH] swiotlb-xen: remove redundant NULL check

In this case hwdev cannot be NULL, so remove redundant NULL check.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: b097186fd29d ("swiotlb-xen: SWIOTLB library for Xen PV guest with PCI passthrough.")
Signed-off-by: Daniil Dulov <d.dulov@...ddin.ru>
---
 drivers/xen/swiotlb-xen.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
index 2b385c1b4a99..b166f6efea26 100644
--- a/drivers/xen/swiotlb-xen.c
+++ b/drivers/xen/swiotlb-xen.c
@@ -305,7 +305,7 @@ xen_swiotlb_alloc_coherent(struct device *hwdev, size_t size,
 	if (!ret)
 		return ret;
 
-	if (hwdev && hwdev->coherent_dma_mask)
+	if (hwdev->coherent_dma_mask)
 		dma_mask = hwdev->coherent_dma_mask;
 
 	/* At this point dma_handle is the dma address, next we are
-- 
2.25.1