linux-kernel - Re: [PATCH v4 02/35] include: remove unnecessary #include directives

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 12 Feb 2024 17:15:12 +0800
From: kernel test robot <lkp@...el.com>
To: Max Kellermann <max.kellermann@...os.com>, linux-kernel@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Max Kellermann <max.kellermann@...os.com>
Subject: Re: [PATCH v4 02/35] include: remove unnecessary #include directives

Hi Max,

kernel test robot noticed the following build warnings:

[auto build test WARNING on next-20240209]
[cannot apply to drm-misc/drm-misc-next media-tree/master mkp-scsi/for-next linus/master v6.8-rc4 v6.8-rc3 v6.8-rc2 v6.8-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Max-Kellermann/include-add-missing-includes/20240212-072756
base:   next-20240209
patch link:    https://lore.kernel.org/r/20240211231518.349442-3-max.kellermann%40ionos.com
patch subject: [PATCH v4 02/35] include: remove unnecessary #include directives
config: powerpc-mpc834x_itxgp_defconfig (https://download.01.org/0day-ci/archive/20240212/202402121640.L0Pwfx8v-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240212/202402121640.L0Pwfx8v-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402121640.L0Pwfx8v-lkp@intel.com/

All warnings (new ones prefixed by >>):

   arch/powerpc/platforms/83xx/misc.c:79:7: error: implicit declaration of function 'of_find_compatible_node' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
           np = of_find_compatible_node(NULL, NULL, "fsl,ipic");
                ^
>> arch/powerpc/platforms/83xx/misc.c:79:5: warning: incompatible integer to pointer conversion assigning to 'struct device_node *' from 'int' [-Wint-conversion]
           np = of_find_compatible_node(NULL, NULL, "fsl,ipic");
              ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/powerpc/platforms/83xx/misc.c:81:8: error: implicit declaration of function 'of_find_node_by_type' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                   np = of_find_node_by_type(NULL, "ipic");
                        ^
   arch/powerpc/platforms/83xx/misc.c:81:6: warning: incompatible integer to pointer conversion assigning to 'struct device_node *' from 'int' [-Wint-conversion]
                   np = of_find_node_by_type(NULL, "ipic");
                      ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/powerpc/platforms/83xx/misc.c:87:2: error: implicit declaration of function 'of_node_put' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
           of_node_put(np);
           ^
   arch/powerpc/platforms/83xx/misc.c:117:2: error: implicit declaration of function 'for_each_compatible_node' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
           for_each_compatible_node(np, "pci", "fsl,mpc8349-pci")
           ^
   arch/powerpc/platforms/83xx/misc.c:117:56: error: expected ';' after expression
           for_each_compatible_node(np, "pci", "fsl,mpc8349-pci")
                                                                 ^
                                                                 ;
   arch/powerpc/platforms/83xx/misc.c:119:57: error: expected ';' after expression
           for_each_compatible_node(np, "pci", "fsl,mpc8314-pcie")
                                                                  ^
                                                                  ;
   2 warnings and 6 errors generated.


vim +79 arch/powerpc/platforms/83xx/misc.c

d4fb5ebd83c704 Dmitry Baryshkov 2011-07-22  73  
d4fb5ebd83c704 Dmitry Baryshkov 2011-07-22  74  void __init mpc83xx_ipic_init_IRQ(void)
d4fb5ebd83c704 Dmitry Baryshkov 2011-07-22  75  {
d4fb5ebd83c704 Dmitry Baryshkov 2011-07-22  76  	struct device_node *np;
d4fb5ebd83c704 Dmitry Baryshkov 2011-07-22  77  
d4fb5ebd83c704 Dmitry Baryshkov 2011-07-22  78  	/* looking for fsl,pq2pro-pic which is asl compatible with fsl,ipic */
d4fb5ebd83c704 Dmitry Baryshkov 2011-07-22 @79  	np = of_find_compatible_node(NULL, NULL, "fsl,ipic");
d4fb5ebd83c704 Dmitry Baryshkov 2011-07-22  80  	if (!np)
d4fb5ebd83c704 Dmitry Baryshkov 2011-07-22  81  		np = of_find_node_by_type(NULL, "ipic");
d4fb5ebd83c704 Dmitry Baryshkov 2011-07-22  82  	if (!np)
d4fb5ebd83c704 Dmitry Baryshkov 2011-07-22  83  		return;
d4fb5ebd83c704 Dmitry Baryshkov 2011-07-22  84  
d4fb5ebd83c704 Dmitry Baryshkov 2011-07-22  85  	ipic_init(np, 0);
d4fb5ebd83c704 Dmitry Baryshkov 2011-07-22  86  
d4fb5ebd83c704 Dmitry Baryshkov 2011-07-22  87  	of_node_put(np);
d4fb5ebd83c704 Dmitry Baryshkov 2011-07-22  88  
d4fb5ebd83c704 Dmitry Baryshkov 2011-07-22  89  	/* Initialize the default interrupt mapping priorities,
d4fb5ebd83c704 Dmitry Baryshkov 2011-07-22  90  	 * in case the boot rom changed something on us.
d4fb5ebd83c704 Dmitry Baryshkov 2011-07-22  91  	 */
d4fb5ebd83c704 Dmitry Baryshkov 2011-07-22  92  	ipic_set_default_priority();
d4fb5ebd83c704 Dmitry Baryshkov 2011-07-22  93  }
d4fb5ebd83c704 Dmitry Baryshkov 2011-07-22  94  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki