linux-kernel - Re: [PATCH v4 02/35] include: remove unnecessary #include directives

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 12 Feb 2024 20:41:15 +0800
From: kernel test robot <lkp@...el.com>
To: Max Kellermann <max.kellermann@...os.com>, linux-kernel@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Max Kellermann <max.kellermann@...os.com>
Subject: Re: [PATCH v4 02/35] include: remove unnecessary #include directives

Hi Max,

kernel test robot noticed the following build errors:

[auto build test ERROR on next-20240209]
[cannot apply to drm-misc/drm-misc-next media-tree/master mkp-scsi/for-next linus/master v6.8-rc4 v6.8-rc3 v6.8-rc2 v6.8-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Max-Kellermann/include-add-missing-includes/20240212-072756
base:   next-20240209
patch link:    https://lore.kernel.org/r/20240211231518.349442-3-max.kellermann%40ionos.com
patch subject: [PATCH v4 02/35] include: remove unnecessary #include directives
config: arm-randconfig-004-20240212 (https://download.01.org/0day-ci/archive/20240212/202402122015.7dytzCz3-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project c08b90c50bcac9f3f563c79491c8dbcbe7c3b574)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240212/202402122015.7dytzCz3-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402122015.7dytzCz3-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/drm_modeset_lock.c:87:6: error: call to undeclared function 'stack_trace_save'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
      87 |         n = stack_trace_save(entries, ARRAY_SIZE(entries), 1);
         |             ^
   drivers/gpu/drm/drm_modeset_lock.c:87:6: note: did you mean 'stack_depot_save'?
   include/linux/stackdepot.h:132:22: note: 'stack_depot_save' declared here
     132 | depot_stack_handle_t stack_depot_save(unsigned long *entries,
         |                      ^
>> drivers/gpu/drm/drm_modeset_lock.c:104:2: error: call to undeclared function 'stack_trace_snprint'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     104 |         stack_trace_snprint(buf, PAGE_SIZE, entries, nr_entries, 2);
         |         ^
   drivers/gpu/drm/drm_modeset_lock.c:104:2: note: did you mean 'stack_depot_snprint'?
   include/linux/stackdepot.h:163:5: note: 'stack_depot_snprint' declared here
     163 | int stack_depot_snprint(depot_stack_handle_t handle, char *buf, size_t size,
         |     ^
   2 errors generated.


vim +/stack_trace_save +87 drivers/gpu/drm/drm_modeset_lock.c

35cf03508d8466 Rob Clark        2016-11-14   80  
cd06ab2fd48f2c Jani Nikula      2021-10-01   81  #if IS_ENABLED(CONFIG_DRM_DEBUG_MODESET_LOCK)
bcae3af286f49b Stephen Rothwell 2021-10-18   82  static noinline depot_stack_handle_t __drm_stack_depot_save(void)
cd06ab2fd48f2c Jani Nikula      2021-10-01   83  {
cd06ab2fd48f2c Jani Nikula      2021-10-01   84  	unsigned long entries[8];
cd06ab2fd48f2c Jani Nikula      2021-10-01   85  	unsigned int n;
cd06ab2fd48f2c Jani Nikula      2021-10-01   86  
cd06ab2fd48f2c Jani Nikula      2021-10-01  @87  	n = stack_trace_save(entries, ARRAY_SIZE(entries), 1);
cd06ab2fd48f2c Jani Nikula      2021-10-01   88  
cd06ab2fd48f2c Jani Nikula      2021-10-01   89  	return stack_depot_save(entries, n, GFP_NOWAIT | __GFP_NOWARN);
cd06ab2fd48f2c Jani Nikula      2021-10-01   90  }
cd06ab2fd48f2c Jani Nikula      2021-10-01   91  
bcae3af286f49b Stephen Rothwell 2021-10-18   92  static void __drm_stack_depot_print(depot_stack_handle_t stack_depot)
cd06ab2fd48f2c Jani Nikula      2021-10-01   93  {
cd06ab2fd48f2c Jani Nikula      2021-10-01   94  	struct drm_printer p = drm_debug_printer("drm_modeset_lock");
cd06ab2fd48f2c Jani Nikula      2021-10-01   95  	unsigned long *entries;
cd06ab2fd48f2c Jani Nikula      2021-10-01   96  	unsigned int nr_entries;
cd06ab2fd48f2c Jani Nikula      2021-10-01   97  	char *buf;
cd06ab2fd48f2c Jani Nikula      2021-10-01   98  
cd06ab2fd48f2c Jani Nikula      2021-10-01   99  	buf = kmalloc(PAGE_SIZE, GFP_NOWAIT | __GFP_NOWARN);
cd06ab2fd48f2c Jani Nikula      2021-10-01  100  	if (!buf)
cd06ab2fd48f2c Jani Nikula      2021-10-01  101  		return;
cd06ab2fd48f2c Jani Nikula      2021-10-01  102  
cd06ab2fd48f2c Jani Nikula      2021-10-01  103  	nr_entries = stack_depot_fetch(stack_depot, &entries);
cd06ab2fd48f2c Jani Nikula      2021-10-01 @104  	stack_trace_snprint(buf, PAGE_SIZE, entries, nr_entries, 2);
cd06ab2fd48f2c Jani Nikula      2021-10-01  105  
cd06ab2fd48f2c Jani Nikula      2021-10-01  106  	drm_printf(&p, "attempting to lock a contended lock without backoff:\n%s", buf);
cd06ab2fd48f2c Jani Nikula      2021-10-01  107  
cd06ab2fd48f2c Jani Nikula      2021-10-01  108  	kfree(buf);
cd06ab2fd48f2c Jani Nikula      2021-10-01  109  }
2dba5eb1c73b6b Vlastimil Babka  2022-01-21  110  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki