[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <27cbed30-64e2-4843-a32b-0c0a5b1643a2@oracle.com>
Date: Tue, 13 Feb 2024 10:15:45 -0500
From: Steven Sistare <steven.sistare@...cle.com>
To: virtualization@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Cc: "Michael S. Tsirkin" <mst@...hat.com>, Jason Wang <jasowang@...hat.com>,
Eugenio Perez Martin <eperezma@...hat.com>,
Si-Wei Liu <si-wei.liu@...cle.com>,
Stefano Garzarella <sgarzare@...hat.com>
Subject: Re: [PATCH V2] vdpa_sim: reset must not run
Changes in V2:
- test DRIVER_OK instead of FEATURES_OK
- post singly, and add RB and acks
- Steve
On 2/9/2024 5:30 PM, Steve Sistare wrote:
> vdpasim_do_reset sets running to true, which is wrong, as it allows
> vdpasim_kick_vq to post work requests before the device has been
> configured. To fix, do not set running until VIRTIO_CONFIG_S_DRIVER_OK
> is set.
>
> Fixes: 0c89e2a3a9d0 ("vdpa_sim: Implement suspend vdpa op")
> Signed-off-by: Steve Sistare <steven.sistare@...cle.com>
> Reviewed-by: Eugenio PĂ©rez <eperezma@...hat.com>
> Acked-by: Jason Wang <jasowang@...hat.com>
> ---
> drivers/vdpa/vdpa_sim/vdpa_sim.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
> index be2925d0d283..18584ce70bf0 100644
> --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c
> +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
> @@ -160,7 +160,7 @@ static void vdpasim_do_reset(struct vdpasim *vdpasim, u32 flags)
> }
> }
>
> - vdpasim->running = true;
> + vdpasim->running = false;
> spin_unlock(&vdpasim->iommu_lock);
>
> vdpasim->features = 0;
> @@ -483,6 +483,7 @@ static void vdpasim_set_status(struct vdpa_device *vdpa, u8 status)
>
> mutex_lock(&vdpasim->mutex);
> vdpasim->status = status;
> + vdpasim->running = (status & VIRTIO_CONFIG_S_DRIVER_OK) != 0;
> mutex_unlock(&vdpasim->mutex);
> }
>
Powered by blists - more mailing lists