[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zcsz7x1rXgYP3e7b@duo.ucw.cz>
Date: Tue, 13 Feb 2024 10:18:39 +0100
From: Pavel Machek <pavel@....cz>
To: Abdel Alkuor <alkuor@...il.com>
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Lukas Bulwahn <lukas.bulwahn@...il.com>,
Jean-Jacques Hiblot <jjhiblot@...phandler.com>,
ChiYuan Huang <cy_huang@...htek.com>,
André Apitzsch <git@...tzsch.eu>,
Alice Chen <alice_chen@...htek.com>,
Jacek Anaszewski <jacek.anaszewski@...il.com>,
ChiaEn Wu <chiaen_wu@...htek.com>, linux-kernel@...r.kernel.org,
linux-leds@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 2/2] leds: Add NCP5623 multi-led driver
Hi!
> .../sysfs-class-led-multicolor-driver-ncp5623 | 46 +++
> drivers/leds/rgb/Kconfig | 11 +
> drivers/leds/rgb/Makefile | 1 +
> drivers/leds/rgb/leds-ncp5623.c | 320 ++++++++++++++++++
> 4 files changed, 378 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-class-led-multicolor-driver-ncp5623
> create mode 100644 drivers/leds/rgb/leds-ncp5623.c
>
> diff --git a/Documentation/ABI/testing/sysfs-class-led-multicolor-driver-ncp5623 b/Documentation/ABI/testing/sysfs-class-led-multicolor-driver-ncp5623
> new file mode 100644
> index 000000000000..6b9f4849852b
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-class-led-multicolor-driver-ncp5623
> @@ -0,0 +1,46 @@
> +What: /sys/class/leds/<led>/direction
> +Date: Feb 2024
> +What: /sys/class/leds/<led>/dim_step
You are reinventing hardware_pattern trigger. NAK.
I suggest you add basic support first, then look at hardware pattern
trigger and add that support in separate patch.
Thanks,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)
Powered by blists - more mailing lists