linux-kernel - Re: [PATCH 2/2] leds: Add NCP5623 multi-led driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZdEp6LuUBI1oMf0z@abdel>
Date: Sat, 17 Feb 2024 16:49:28 -0500
From: Abdel Alkuor <alkuor@...il.com>
To: Pavel Machek <pavel@....cz>
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Lukas Bulwahn <lukas.bulwahn@...il.com>,
	Jean-Jacques Hiblot <jjhiblot@...phandler.com>,
	ChiYuan Huang <cy_huang@...htek.com>,
	André Apitzsch <git@...tzsch.eu>,
	Jacek Anaszewski <jacek.anaszewski@...il.com>,
	ChiaEn Wu <chiaen_wu@...htek.com>, linux-kernel@...r.kernel.org,
	linux-leds@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 2/2] leds: Add NCP5623 multi-led driver

On Tue, Feb 13, 2024 at 10:18:39AM +0100, Pavel Machek wrote:
Hi Pavel,
> > +What:		/sys/class/leds/<led>/dim_step
> 
> You are reinventing hardware_pattern trigger. NAK.
> 
> I suggest you add basic support first, then look at hardware pattern
> trigger and add that support in separate patch.
>
This makes a lot of sense and simplifies the driver.

I'd like to add the hardware pattern as part of this patch as it is already
implemented previously but I needed to do some clean up :)

Thanks,
Abdel