linux-kernel - Re: [PATCH v1 1/1] kernel.h: Move upper_*_bits() and lower_*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zc0CcNbpFrkkqiow@smile.fi.intel.com>
Date: Wed, 14 Feb 2024 20:12:00 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kernel@...r.kernel.org, Kees Cook <keescook@...omium.org>,
	Michal Wajdeczko <michal.wajdeczko@...el.com>
Subject: Re: [PATCH v1 1/1] kernel.h: Move upper_*_bits() and lower_*_bits()
 to wordpath.h

On Wed, Feb 14, 2024 at 10:09:10AM -0800, Randy Dunlap wrote:
> On 2/14/24 09:26, Andy Shevchenko wrote:
> > The wordpart.h header is collecting APIs related to the handling
> > parts of the word (usually in byte granularity). The upper_*_bits()
> > and lower_*_bits() are good candidates to be moved to there.
> > 
> > This helps to clean up header dependency hell with regard to kernel.h
> > as the latter gathers completely unrelated stuff together and slows
> > down compilation (especially when it's included into other header).
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > ---
> > 
> > Kees, since wordpart.h is now only in your tree, this is supposed
> > to go there as well.
> 
> after someone corrects the Subject (wordpath -> wordpart).

Oh, indeed. Thanks for spotting this!
Kees, should I send a v2 or you can amend when applying?

> Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Thanks!

-- 
With Best Regards,
Andy Shevchenko