lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 14 Feb 2024 10:54:47 -0800
From: Kees Cook <keescook@...omium.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org,
	Michal Wajdeczko <michal.wajdeczko@...el.com>
Subject: Re: [PATCH v1 1/1] kernel.h: Move upper_*_bits() and lower_*_bits()
 to wordpath.h

On Wed, Feb 14, 2024 at 08:12:00PM +0200, Andy Shevchenko wrote:
> On Wed, Feb 14, 2024 at 10:09:10AM -0800, Randy Dunlap wrote:
> > On 2/14/24 09:26, Andy Shevchenko wrote:
> > > The wordpart.h header is collecting APIs related to the handling
> > > parts of the word (usually in byte granularity). The upper_*_bits()
> > > and lower_*_bits() are good candidates to be moved to there.
> > > 
> > > This helps to clean up header dependency hell with regard to kernel.h
> > > as the latter gathers completely unrelated stuff together and slows
> > > down compilation (especially when it's included into other header).
> > > 
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > > ---
> > > 
> > > Kees, since wordpart.h is now only in your tree, this is supposed
> > > to go there as well.
> > 
> > after someone corrects the Subject (wordpath -> wordpart).
> 
> Oh, indeed. Thanks for spotting this!
> Kees, should I send a v2 or you can amend when applying?

I've amended it; thanks for the catch Randy!

-Kees

> 
> > Reviewed-by: Randy Dunlap <rdunlap@...radead.org>
> 
> Thanks!
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 

-- 
Kees Cook

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ