linux-kernel - Re: [PATCH] brcmsmac: avoid function pointer casts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <170790035300.3179441.9169506478575963188.kvalo@kernel.org>
Date: Wed, 14 Feb 2024 08:45:55 +0000 (UTC)
From: Kalle Valo <kvalo@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Arend van Spriel <arend.vanspriel@...adcom.com>,
 Nathan Chancellor <nathan@...nel.org>, Greg Kroah-Hartman <gregkh@...e.de>,
 Pieter-Paul Giesberts <pieterpg@...adcom.com>, Arnd Bergmann <arnd@...db.de>,
 Nick Desaulniers <ndesaulniers@...gle.com>, Bill Wendling <morbo@...gle.com>,
 Justin Stitt <justinstitt@...gle.com>,
 Artem Chernyshev <artem.chernyshev@...-soft.ru>,
 Jonas Gorski <jonas.gorski@...il.com>, linux-wireless@...r.kernel.org,
 brcm80211@...ts.linux.dev, brcm80211-dev-list.pdl@...adcom.com,
 linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] brcmsmac: avoid function pointer casts

Arnd Bergmann <arnd@...nel.org> wrote:

> From: Arnd Bergmann <arnd@...db.de>
> 
> An old cleanup went a little too far and causes a warning with clang-16
> and higher as it breaks control flow integrity (KCFI) rules:
> 
> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy_shim.c:64:34: error: cast from 'void (*)(struct brcms_phy *)' to 'void (*)(void *)' converts to incompatible function type [-Werror,-Wcast-function-type-strict]
>    64 |                         brcms_init_timer(physhim->wl, (void (*)(void *))fn,
>       |                                                       ^~~~~~~~~~~~~~~~~~~~
> 
> Change this one instance back to passing a void pointer so it can be
> used with the timer callback interface.
> 
> Fixes: d89a4c80601d ("staging: brcm80211: removed void * from softmac phy")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

I guess this should go to wireless tree?

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20240213100548.457854-1-arnd@kernel.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches