linux-kernel - Re: [PATCH] brcmsmac: avoid function pointer casts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd36f032-3bf6-4cae-a0d0-213604cef024@broadcom.com>
Date: Wed, 14 Feb 2024 10:23:59 +0100
From: Arend van Spriel <arend.vanspriel@...adcom.com>
To: Kalle Valo <kvalo@...nel.org>, Arnd Bergmann <arnd@...nel.org>
Cc: Nathan Chancellor <nathan@...nel.org>, Greg Kroah-Hartman
 <gregkh@...e.de>, Pieter-Paul Giesberts <pieterpg@...adcom.com>,
 Arnd Bergmann <arnd@...db.de>, Nick Desaulniers <ndesaulniers@...gle.com>,
 Bill Wendling <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>,
 Artem Chernyshev <artem.chernyshev@...-soft.ru>,
 Jonas Gorski <jonas.gorski@...il.com>, linux-wireless@...r.kernel.org,
 brcm80211@...ts.linux.dev, brcm80211-dev-list.pdl@...adcom.com,
 linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] brcmsmac: avoid function pointer casts

On 2/14/2024 9:45 AM, Kalle Valo wrote:
> Arnd Bergmann <arnd@...nel.org> wrote:
> 
>> From: Arnd Bergmann <arnd@...db.de>
>>
>> An old cleanup went a little too far and causes a warning with clang-16
>> and higher as it breaks control flow integrity (KCFI) rules:
>>
>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy_shim.c:64:34: error: cast from 'void (*)(struct brcms_phy *)' to 'void (*)(void *)' converts to incompatible function type [-Werror,-Wcast-function-type-strict]
>>     64 |                         brcms_init_timer(physhim->wl, (void (*)(void *))fn,
>>        |                                                       ^~~~~~~~~~~~~~~~~~~~
>>
>> Change this one instance back to passing a void pointer so it can be
>> used with the timer callback interface.
>>
>> Fixes: d89a4c80601d ("staging: brcm80211: removed void * from softmac phy")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> I guess this should go to wireless tree?

This has been like this forever looking at the "staging" part in the 
Fixes tag. Is it really so urgent now? On the other hand I have no real 
problem with moving this to the wireless tree. Just wondering out loud.

Regards,
Arend

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4219 bytes)