linux-kernel - Re: [PATCH v2 1/2] arm64: dts: ti: k3-am69-sk: fix PMIC interrupt number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <75241296-c698-4983-9dcd-9f59c31cb286@ti.com>
Date: Wed, 14 Feb 2024 15:03:18 +0530
From: Neha Malcom Francis <n-francis@...com>
To: Romain Naour <romain.naour@...le.fr>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <conor+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <robh+dt@...nel.org>, <kristo@...nel.org>, <vigneshr@...com>,
        <nm@...com>
Subject: Re: [PATCH v2 1/2] arm64: dts: ti: k3-am69-sk: fix PMIC interrupt
 number

Hi Romain

On 09/02/24 22:41, Romain Naour wrote:
> The tps659413 node set WKUP_GPIO0_83 (AA37) pin as input to be used as
> PMIC interrupt but uses 39 (WKUP_GPIO0_39) as "interrupts" property.
> 
> Replace 39 by 83 after checking in the board schematic [1].
> 
> [1] https://www.ti.com/tool/SK-AM69
> 
> Fixes: 865a1593bf99 ("arm64: dts: ti: k3-am69-sk: Add support for TPS6594 PMIC")
> Cc: Neha Malcom Francis <n-francis@...com>
> Signed-off-by: Romain Naour <romain.naour@...le.fr>
> ---
>   arch/arm64/boot/dts/ti/k3-am69-sk.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am69-sk.dts b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
> index 8da591579868..95c9d3da59d3 100644
> --- a/arch/arm64/boot/dts/ti/k3-am69-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
> @@ -646,7 +646,7 @@ tps659413: pmic@48 {
>   		pinctrl-names = "default";
>   		pinctrl-0 = <&pmic_irq_pins_default>;
>   		interrupt-parent = <&wkup_gpio0>;
> -		interrupts = <39 IRQ_TYPE_EDGE_FALLING>;
> +		interrupts = <83 IRQ_TYPE_EDGE_FALLING>;
>   		gpio-controller;
>   		#gpio-cells = <2>;
>   		ti,primary-pmic;

Thanks for catching this!

Reviewed-by: Neha Malcom Francis <n-francis@...com>

-- 
Thanking You
Neha Malcom Francis