linux-kernel - Re: [PATCH v2 2/2] arm64: dts: ti: k3-j721e-sk: fix PMIC interrupt number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a8ed43ca-d2fb-4dce-ba9f-9c52e5a05b1a@ti.com>
Date: Wed, 14 Feb 2024 15:03:36 +0530
From: Neha Malcom Francis <n-francis@...com>
To: Romain Naour <romain.naour@...le.fr>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <conor+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <robh+dt@...nel.org>, <kristo@...nel.org>, <vigneshr@...com>,
        <nm@...com>
Subject: Re: [PATCH v2 2/2] arm64: dts: ti: k3-j721e-sk: fix PMIC interrupt
 number

On 09/02/24 22:41, Romain Naour wrote:
> The tps659413 and tps659411 nodes set WKUP_GPIO0_7 (G28) pin as input
> to be used as PMIC interrupt but uses 9 (WKUP_GPIO0_9) as
> "interrupts" property.
> 
> Replace 9 by 7 for both tps659413 and tps659411 after checking in the
> board schematic [1].
> 
> [1] https://www.ti.com/tool/SK-TDA4VM
> 
> Fixes: b808cef0be46 ("arm64: dts: ti: k3-j721e-sk: Add TPS6594 family PMICs")
> Cc: Neha Malcom Francis <n-francis@...com>
> Signed-off-by: Romain Naour <romain.naour@...le.fr>
> ---
> v2: update tps659411 interrupts parameter too.
> ---
>   arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> index 188dfe291a32..658764f7d544 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> @@ -574,7 +574,7 @@ tps659413: pmic@48 {
>   		pinctrl-names = "default";
>   		pinctrl-0 = <&pmic_irq_pins_default>;
>   		interrupt-parent = <&wkup_gpio0>;
> -		interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
> +		interrupts = <7 IRQ_TYPE_EDGE_FALLING>;
>   		gpio-controller;
>   		#gpio-cells = <2>;
>   		ti,primary-pmic;
> @@ -651,7 +651,7 @@ tps659411: pmic@4c {
>   		reg = <0x4c>;
>   		system-power-controller;
>   		interrupt-parent = <&wkup_gpio0>;
> -		interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
> +		interrupts = <7 IRQ_TYPE_EDGE_FALLING>;
>   		gpio-controller;
>   		#gpio-cells = <2>;
>   		buck1234-supply = <&vsys_3v3>;


Reviewed-by: Neha Malcom Francis <n-francis@...com>

-- 
Thanking You
Neha Malcom Francis