linux-kernel - Re: [PATCH v2] misc: eeprom/idt_89hpesx: Convert data structures to LE explicitly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 14 Feb 2024 18:05:46 +0800
From: Dawei Li <dawei.li@...ngroup.cn>
To: arnd@...db.de, gregkh@...uxfoundation.org
Cc: fancer.lancer@...il.com, lkp@...el.com, linux-kernel@...r.kernel.org,
	set_pte_at@...look.com
Subject: Re: [PATCH v2] misc: eeprom/idt_89hpesx: Convert data structures to
 LE explicitly

Hi Greg,

Sorry for bothering.

On Wed, Jan 31, 2024 at 11:30:28AM +0800, Dawei Li wrote:
> Kernel test robot reports following sparse warnings:
> >> drivers/misc/eeprom/idt_89hpesx.c:599:31: sparse: sparse:
>    incorrect type in assignment (different base types) @@
>    expected unsigned short [addressable] [assigned] [usertype]
>    memaddr @@     got restricted __le16 [usertype] @@
> 
>    drivers/misc/eeprom/idt_89hpesx.c:599:31: sparse:
>    expected unsigned short [addressable] [assigned] [usertype]
>    memaddr
> 
>    drivers/misc/eeprom/idt_89hpesx.c:599:31: sparse:
>    restricted __le16 [usertype]
> 
>    .....
> 
> For data structures needs cpu_to_le* conversion, their prototype need
> to be declared with __le* explicitly.
> 
> Declare data structures to __le* explicitly to address the issue:
> - struct idt_eeprom_seq::memaddr
> - struct idt_csr_seq::csraddr
> - struct idt_csr_seq::data
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202401261250.b07Yt30Z-lkp@intel.com/
> Signed-off-by: Dawei Li <dawei.li@...ngroup.cn>
> Reviewed-by: Serge Semin <fancer.lancer@...il.com>
> ---
> v1 -> v2:
> - Add sparse warning info from Kernel test robot.
> - Remove Fixes & cc stable tag.
> - Add Reviewed-by from Serge.
> 
> v1: https://lore.kernel.org/all/20240130040632.3039911-1-dawei.li@shingroup.cn/
> 

Any comments on this?

Thanks,

    Dawei

>  drivers/misc/eeprom/idt_89hpesx.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c
> index d807d08e2614..327afb866b21 100644
> --- a/drivers/misc/eeprom/idt_89hpesx.c
> +++ b/drivers/misc/eeprom/idt_89hpesx.c
> @@ -129,7 +129,7 @@ struct idt_smb_seq {
>  struct idt_eeprom_seq {
>  	u8 cmd;
>  	u8 eeaddr;
> -	u16 memaddr;
> +	__le16 memaddr;
>  	u8 data;
>  } __packed;
>  
> @@ -141,8 +141,8 @@ struct idt_eeprom_seq {
>   */
>  struct idt_csr_seq {
>  	u8 cmd;
> -	u16 csraddr;
> -	u32 data;
> +	__le16 csraddr;
> +	__le32 data;
>  } __packed;
>  
>  /*
> -- 
> 2.27.0
>