linux-kernel - Re: [PATCH v2] misc: eeprom/idt_89hpesx: Convert data structures to LE explicitly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <2780b965-02fe-41fd-ae16-98f7619aeed2@app.fastmail.com>
Date: Wed, 14 Feb 2024 11:17:06 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Dawei Li" <dawei.li@...ngroup.cn>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Cc: "Serge Semin" <fancer.lancer@...il.com>,
 "kernel test robot" <lkp@...el.com>, linux-kernel@...r.kernel.org,
 "Dawei Li" <set_pte_at@...look.com>
Subject: Re: [PATCH v2] misc: eeprom/idt_89hpesx: Convert data structures to LE
 explicitly

On Wed, Jan 31, 2024, at 04:30, Dawei Li wrote:
> Kernel test robot reports following sparse warnings:
>>> drivers/misc/eeprom/idt_89hpesx.c:599:31: sparse: sparse:
>    incorrect type in assignment (different base types) @@
>    expected unsigned short [addressable] [assigned] [usertype]
>    memaddr @@     got restricted __le16 [usertype] @@
>
>    drivers/misc/eeprom/idt_89hpesx.c:599:31: sparse:
>    expected unsigned short [addressable] [assigned] [usertype]
>    memaddr
>
>    drivers/misc/eeprom/idt_89hpesx.c:599:31: sparse:
>    restricted __le16 [usertype]
>
>    .....
>
> For data structures needs cpu_to_le* conversion, their prototype need
> to be declared with __le* explicitly.
>
> Declare data structures to __le* explicitly to address the issue:
> - struct idt_eeprom_seq::memaddr
> - struct idt_csr_seq::csraddr
> - struct idt_csr_seq::data
>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: 
> https://lore.kernel.org/oe-kbuild-all/202401261250.b07Yt30Z-lkp@intel.com/
> Signed-off-by: Dawei Li <dawei.li@...ngroup.cn>
> Reviewed-by: Serge Semin <fancer.lancer@...il.com>

Acked-by: Arnd Bergmann <arnd@...db.de>