[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240214121448.451e2e1c@booty>
Date: Wed, 14 Feb 2024 12:14:48 +0100
From: Luca Ceresoli <luca.ceresoli@...tlin.com>
To: Adam Ford <aford173@...il.com>
Cc: linux-arm-kernel@...ts.infradead.org, marex@...x.de,
aford@...conembedded.com, Lucas Stach <l.stach@...gutronix.de>, Richard
Leitner <richard.leitner@...data.com>, Marco Felsch
<m.felsch@...gutronix.de>, Alexander Stein
<alexander.stein@...tq-group.com>, Frieder Schrempf
<frieder.schrempf@...tron.de>, Vinod Koul <vkoul@...nel.org>, Kishon Vijay
Abraham I <kishon@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof
Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley
<conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer
<s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>, NXP Linux Team <linux-imx@....com>,
Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH V4 2/6] phy: freescale: add Samsung HDMI PHY
On Sat, 10 Feb 2024 14:45:58 -0600
Adam Ford <aford173@...il.com> wrote:
> From: Lucas Stach <l.stach@...gutronix.de>
>
> This adds the driver for the Samsung HDMI PHY found on the
> i.MX8MP SoC. Based on downstream implementation from
> Sandor Yu <Sandor.yu@....com>. According to the TRM, the PHY
> receives parallel data from the link and serializes it. It
> also sets the PLL clock needed for the TX serializer.
>
> Tested-by: Luca Ceresoli <luca.ceresoli@...tlin.com> (v2)
> Tested-by: Richard Leitner <richard.leitner@...data.com> (v2)
> Co-developed-by: Marco Felsch <m.felsch@...gutronix.de>
> Signed-off-by: Marco Felsch <m.felsch@...gutronix.de>
> Signed-off-by: Lucas Stach <l.stach@...gutronix.de>
> Tested-by: Alexander Stein <alexander.stein@...tq-group.com>
> Tested-by: Frieder Schrempf <frieder.schrempf@...tron.de> # Kontron BL
> Tested-by: Luca Ceresoli <luca.ceresoli@...tlin.com>
> Signed-off-by: Adam Ford <aford173@...il.com>
[...]
> +static int phy_clk_register(struct fsl_samsung_hdmi_phy *phy)
> +{
> + struct device *dev = phy->dev;
> + struct device_node *np = dev->of_node;
> + struct clk_init_data init;
> + const char *parent_name;
> + struct clk *phyclk;
> + int ret;
> +
> + parent_name = __clk_get_name(phy->refclk);
> +
> + init.parent_names = &parent_name;
> + init.num_parents = 1;
> + init.flags = 0;
> + init.name = "hdmi_pclk";
> + init.ops = &phy_clk_ops;
> +
> + phy->hw.init = &init;
> +
> + phyclk = devm_clk_register(dev, &phy->hw);
> + if (IS_ERR(phyclk))
> + return dev_err_probe(dev, PTR_ERR(phyclk),
> + "failed to register clock\n");
> +
> + ret = of_clk_add_provider(np, of_clk_src_simple_get, phyclk);
As per my v8 review, this function is deprecated:
https://elixir.bootlin.com/linux/v6.8-rc4/source/drivers/clk/clk.c#L4881
However:
[Tested using Avnet MSC SM2S-IMX8PLUS SoM on Avnet MSC SM2-MB-EP1]
Tested-by: Luca Ceresoli <luca.ceresoli@...tlin.com>
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Powered by blists - more mailing lists