linux-kernel - Re: [PATCH v3 3/7] arm64: dts: ti: iot2050: Factor out arduino connector bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <78aac8b5-4ae0-4a0d-9b74-35bf88e3cbf2@siemens.com>
Date: Wed, 14 Feb 2024 12:21:53 +0100
From: Jan Kiszka <jan.kiszka@...mens.com>
To: Vignesh Raghavendra <vigneshr@...com>, Nishanth Menon <nm@...com>,
 Tero Kristo <kristo@...nel.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, Bao Cheng Su <baocheng.su@...mens.com>
Subject: Re: [PATCH v3 3/7] arm64: dts: ti: iot2050: Factor out arduino
 connector bits

On 14.02.24 11:13, Vignesh Raghavendra wrote:
> 
> 
> On 09/02/24 12:53, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@...mens.com>
>>
>> A new variant is to be added which will not have a arduino connector
>> like the existing ones. Factor out all bits that are specific to this
>> connector.
>>
>> The split is not perfect because wkup_gpio0 is defined based on what is
>> common to all variants having the connector, thus containing also
>> connector-unrelated information. But this is still cleaner than
>> replicating this node into all 4 variants.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>
>> ---
>>  .../ti/k3-am65-iot2050-arduino-connector.dtsi | 768 ++++++++++++++++++
>>  .../boot/dts/ti/k3-am65-iot2050-common.dtsi   | 753 -----------------
>>  .../ti/k3-am6528-iot2050-basic-common.dtsi    |   1 +
>>  .../dts/ti/k3-am6548-iot2050-advanced-m2.dts  |   1 +
>>  .../dts/ti/k3-am6548-iot2050-advanced-pg2.dts |   1 +
>>  .../dts/ti/k3-am6548-iot2050-advanced.dts     |   1 +
>>  6 files changed, 772 insertions(+), 753 deletions(-)
>>  create mode 100644 
>> arch/arm64/boot/dts/ti/k3-am65-iot2050-arduino-connector.dtsi
>>
>> diff --git 
>> a/arch/arm64/boot/dts/ti/k3-am65-iot2050-arduino-connector.dtsi 
>> b/arch/arm64/boot/dts/ti/k3-am65-iot2050-arduino-connector.dtsi
>> new file mode 100644
>> index 000000000000..cd86f412b837
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-arduino-connector.dtsi
>> @@ -0,0 +1,768 @@
>> +// SPDX-License-Identifier: GPL-2.0
> 
> This and elsewhere in the series should be
> 
> // SPDX-License-Identifier: GPL-2.0-only
> 
> as fixed up by Nishanth in [0]. I can fix that locally, let me know.
> 

Yes, please.

> [0] https://lore.kernel.org/r/20240122145539.194512-16-nm@ti.com
> 

Thanks,
Jan

-- 
Siemens AG, Technology
Linux Expert Center