linux-kernel - Re: [PATCH 1/7] HID: apple: remove unused members from struct apple_sc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 14 Feb 2024 12:54:37 +0000
From: Aditya Garg <gargaditya08@...e.com>
To: "Jiri Slaby (SUSE)" <jirislaby@...nel.org>
CC: "jikos@...nel.org" <jikos@...nel.org>, "linux-input@...r.kernel.org"
	<linux-input@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Paul Pawlowski <paul@...rm.io>, Aun-Ali Zaidi
	<admin@...eit.net>, Benjamin Tissoires <benjamin.tissoires@...hat.com>
Subject: Re: [PATCH 1/7] HID: apple: remove unused members from struct
 apple_sc_backlight

Hi Jiri

I got this patch tested by a user and no regression was reported.

Thanks

> On 01-Feb-2024, at 5:23 PM, Jiri Slaby (SUSE) <jirislaby@...nel.org> wrote:
> 
> The backlight members in struct apple_sc_backlight are unused. They were
> added in commit 9018eacbe623 (HID: apple: Add support for keyboard
> backlight on certain T2 Macs.), but never used.
> 
> As this is not a struct to communicate with the HW, remove these.
> 
> Found by https://github.com/jirislaby/clang-struct.
> 
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
> Cc: Paul Pawlowski <paul@...rm.io>
> Cc: Aun-Ali Zaidi <admin@...eit.net>
> Cc: Aditya Garg <gargaditya08@...e.com>
> Cc: Jiri Kosina <jikos@...nel.org>
> Cc: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> ---
> drivers/hid/hid-apple.c | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
> index b9c7c0ed7bcc..bd022e004356 100644
> --- a/drivers/hid/hid-apple.c
> +++ b/drivers/hid/hid-apple.c
> @@ -79,7 +79,6 @@ struct apple_non_apple_keyboard {
> struct apple_sc_backlight {
>    struct led_classdev cdev;
>    struct hid_device *hdev;
> -    unsigned short backlight_off, backlight_on_min, backlight_on_max;
> };
> 
> struct apple_sc {
> --
> 2.43.0
>