linux-kernel - Re: [PATCH v3 0/5] DesignWare PWM improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8a580aad-001c-4e88-8f56-271f1835e581@linux.intel.com>
Date: Wed, 14 Feb 2024 14:55:09 +0200
From: Jarkko Nikula <jarkko.nikula@...ux.intel.com>
To: Raag Jadav <raag.jadav@...el.com>, u.kleine-koenig@...gutronix.de,
 mika.westerberg@...ux.intel.com, andriy.shevchenko@...ux.intel.com,
 lakshmi.sowjanya.d@...el.com
Cc: linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/5] DesignWare PWM improvements

On 2/12/24 15:02, Raag Jadav wrote:
> This series implements 16 channel PWM support for Intel Elkhart Lake
> along with minor cleanups for DesignWare PWM driver.
> 
> Changes since v2:
> - Remove error code duplication from dev_err_probe()
> - Update tags
> 
> Changes since v1:
> - Drop redundant error check
> - Provide dwc_pwm_init_one() to initialize one PWM instance
> - Use dev_get_drvdata() instead of pci_get_drvdata()
> - Use pm_sleep_ptr() instead of use pm_ptr()
> 
> Raag Jadav (5):
>    pwm: dwc: use pm_sleep_ptr() macro
>    pwm: dwc: drop redundant error check
>    pwm: dwc: Add 16 channel support for Intel Elkhart Lake
>    pwm: dwc: simplify error handling
>    pwm: dwc: access driver_data using dev_get_drvdata()
> 
>   drivers/pwm/pwm-dwc.c | 59 ++++++++++++++++++++++++-------------------
>   drivers/pwm/pwm-dwc.h |  5 ++++
>   2 files changed, 38 insertions(+), 26 deletions(-)
> 
I tested on Elkhart lake this patchset and it adds another 8 channel PWM 
instance and the PCI device continue switching between D0 and D3 power 
states depending is some channel enabled or all idle.

Tested-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>