linux-kernel - Re: [PATCH v1 1/1] input: touchcreen: tsc2007: make interrupt optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zc5QANGhS8EPvgEy@google.com>
Date: Thu, 15 Feb 2024 09:55:12 -0800
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Svyatoslav Ryhel <clamor95@...il.com>
Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
	Benjamin Bara <benjamin.bara@...data.com>,
	Richard Leitner <richard.leitner@...ux.dev>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] input: touchcreen: tsc2007: make interrupt
 optional

Hi Svyatoslav,

On Sat, Feb 10, 2024 at 07:55:30PM +0200, Svyatoslav Ryhel wrote:
> In case tsc2007 is used as an ADC sensor there will be no interrupt
> provided at all, so set up an interrupt only if one is present and
> remove associated warning.

If we want to do this, we should better handle the input device portion
of the driver. We have 2 options:

- switch the input device into polling mode when interrupt is absent
- do not create input device

Those do not need to be mutually exclusive (i.e. we could use absence of
both device tree interrupt property as well as lack of poll-interval
property to suppress creation of the input device and only leave iio.

Thanks.

-- 
Dmitry