linux-kernel - Re: [PATCH v1 1/1] input: touchcreen: tsc2007: make interrupt optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPVz0n3DA6PiJOhkX-0Lk1QXjaKa9NkLkDRkV85Z3S2S5S8Ogg@mail.gmail.com>
Date: Thu, 15 Feb 2024 20:09:35 +0200
From: Svyatoslav Ryhel <clamor95@...il.com>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, 
	Benjamin Bara <benjamin.bara@...data.com>, Richard Leitner <richard.leitner@...ux.dev>, 
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] input: touchcreen: tsc2007: make interrupt optional

чт, 15 лют. 2024 р. о 19:55 Dmitry Torokhov <dmitry.torokhov@...il.com> пише:
>
> Hi Svyatoslav,
>
> On Sat, Feb 10, 2024 at 07:55:30PM +0200, Svyatoslav Ryhel wrote:
> > In case tsc2007 is used as an ADC sensor there will be no interrupt
> > provided at all, so set up an interrupt only if one is present and
> > remove associated warning.
>
> If we want to do this, we should better handle the input device portion
> of the driver. We have 2 options:
>
> - switch the input device into polling mode when interrupt is absent
> - do not create input device
>
> Those do not need to be mutually exclusive (i.e. we could use absence of
> both device tree interrupt property as well as lack of poll-interval
> property to suppress creation of the input device and only leave iio.
>
> Thanks.
>

I do not care about input part and suppressing it is perfectly fine for me.
Which implementation would be accepted?
I suppose I may isolate input device creation into separate function and
add check for interrupt or poll-interval. If both are not present then input
device creation will be skipped. Will this be sufficient?

> --
> Dmitry